Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Issue 2378543002: (Reland) Port WebGL extension availability tests to the integration test harness. (Closed)
Patch Set: Skip WebglExtension_WEBGL_compressed_texture_s3tc_srgb on Android too. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
diff --git a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
index e5498dc896dc1a1b3223c898856e1821396f18c2..a5bee6f24e0801e2ec81f5302fae3bfb0168b542 100644
--- a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
+++ b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
@@ -6,8 +6,9 @@ from gpu_tests.webgl_conformance_expectations import WebGLConformanceExpectation
# See the GpuTestExpectations class for documentation.
class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
- def __init__(self, conformance_path):
- super(WebGL2ConformanceExpectations, self).__init__(conformance_path)
+ def __init__(self, conformance_path, url_prefixes=None):
+ super(WebGL2ConformanceExpectations, self).__init__(
+ conformance_path, url_prefixes=url_prefixes)
def SetExpectations(self):
# ===================================
@@ -16,13 +17,20 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):
# It's expected that not all extensions will be available on all platforms.
# Having a test listed here is not necessarily a problem.
- self.Fail('WebglExtension.WEBGL_compressed_texture_astc',
+ # Skip these, rather than expect them to fail, to speed up test
+ # execution. The browser is restarted even after expected test
+ # failures.
+ self.Skip('WebglExtension_WEBGL_compressed_texture_astc',
['win', 'mac', 'linux'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_atc',
+ self.Skip('WebglExtension_WEBGL_compressed_texture_atc',
['win', 'mac', 'linux'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_etc1',
+ self.Skip('WebglExtension_WEBGL_compressed_texture_es3_0',
+ ['linux', 'mac'])
+ self.Skip('WebglExtension_WEBGL_compressed_texture_etc1',
['mac', 'linux'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_pvrtc',
+ self.Skip('WebglExtension_WEBGL_compressed_texture_pvrtc',
+ ['win', 'mac', 'linux'])
+ self.Skip('WebglExtension_WEBGL_compressed_texture_s3tc_srgb',
['win', 'mac', 'linux'])
# ========================
« no previous file with comments | « content/test/gpu/gpu_tests/test_expectations_unittest.py ('k') | content/test/gpu/gpu_tests/webgl_conformance_expectations.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698