Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2297673002: Port WebGL extension availability tests to the integration test harness. (Closed)

Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port WebGL extension availability tests to the integration test harness. These were accidentally lost during the switch to the new test harness. Convert the expectations to the new format of the test names. The old tests aren't being run anywhere any more and will be deleted. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ce19d57eda179fe9b47d00159eb25bc025712c9b Cr-Commit-Position: refs/heads/master@{#421111}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix apparent race conditions in newly ported extension tests. #

Patch Set 3 : Skip non-desktop compressed texture extension tests on WebGL2 too. #

Patch Set 4 : Add URL prefixes to handle multiple static server dirs. #

Patch Set 5 : Add WEBGL_compressed_texture_es3_0 and WEBGL_compressed_texture_s3tc_srgb. #

Patch Set 6 : WEBGL_compressed_texture_es3_0 is not available on desktop Linux. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -38 lines) Patch
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_test_expectations.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/test_expectations.py View 1 2 3 2 chunks +12 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 4 5 2 chunks +14 lines, -6 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 3 4 4 chunks +34 lines, -26 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 1 2 3 4 5 chunks +147 lines, -5 lines 0 comments Download

Messages

Total messages: 43 (23 generated)
Ken Russell (switch to Gerrit)
Emily, Ned, Mo: please review. Thanks. https://codereview.chromium.org/2297673002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py File content/test/gpu/gpu_tests/webgl_conformance_integration_test.py (right): https://codereview.chromium.org/2297673002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py#newcode143 content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:143: def _RunExtensionCoverageTest(self, test_path, ...
4 years, 3 months ago (2016-08-30 13:11:29 UTC) #3
nednguyen
On 2016/08/30 13:11:29, Ken Russell wrote: > Emily, Ned, Mo: please review. Thanks. > > ...
4 years, 3 months ago (2016-08-30 13:33:38 UTC) #6
eyaich1
On 2016/08/30 13:33:38, nednguyen wrote: > On 2016/08/30 13:11:29, Ken Russell wrote: > > Emily, ...
4 years, 3 months ago (2016-08-30 13:56:35 UTC) #7
Zhenyao Mo
lgtm
4 years, 3 months ago (2016-08-30 19:15:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297673002/40001
4 years, 3 months ago (2016-08-31 00:10:26 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/3043)
4 years, 3 months ago (2016-08-31 01:08:02 UTC) #15
Ken Russell (switch to Gerrit)
Fixed breakage of test expectations due to specification of multiple directories in SetStaticServerDirs by adding ...
4 years, 2 months ago (2016-09-25 22:56:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297673002/60001
4 years, 2 months ago (2016-09-25 22:57:39 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_gpu_tests_rel/builds/2863)
4 years, 2 months ago (2016-09-25 23:57:50 UTC) #21
Ken Russell (switch to Gerrit)
CC'ing Kai. Kai, this test verifies the availability of the two new extensions you've been ...
4 years, 2 months ago (2016-09-26 00:53:25 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297673002/80001
4 years, 2 months ago (2016-09-26 00:53:44 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/302483)
4 years, 2 months ago (2016-09-26 01:36:14 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297673002/100001
4 years, 2 months ago (2016-09-26 17:30:13 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148177)
4 years, 2 months ago (2016-09-26 20:27:03 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297673002/100001
4 years, 2 months ago (2016-09-26 20:57:19 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148488)
4 years, 2 months ago (2016-09-26 23:48:57 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297673002/100001
4 years, 2 months ago (2016-09-27 03:55:15 UTC) #38
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-09-27 05:02:57 UTC) #40
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/ce19d57eda179fe9b47d00159eb25bc025712c9b Cr-Commit-Position: refs/heads/master@{#421111}
4 years, 2 months ago (2016-09-27 05:03:47 UTC) #42
Ken Russell (switch to Gerrit)
4 years, 2 months ago (2016-09-27 23:12:09 UTC) #43
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2369373003/ by kbr@chromium.org.

The reason for reverting is: Seems to have broken wildcard test expectations:
http://crbug.com/650711.

Powered by Google App Engine
This is Rietveld 408576698