|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 2 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Kai Ninomiya Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPort WebGL extension availability tests to the integration test harness.
These were accidentally lost during the switch to the new test harness.
Convert the expectations to the new format of the test names. The old
tests aren't being run anywhere any more and will be deleted.
BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/ce19d57eda179fe9b47d00159eb25bc025712c9b
Cr-Commit-Position: refs/heads/master@{#421111}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix apparent race conditions in newly ported extension tests. #Patch Set 3 : Skip non-desktop compressed texture extension tests on WebGL2 too. #Patch Set 4 : Add URL prefixes to handle multiple static server dirs. #Patch Set 5 : Add WEBGL_compressed_texture_es3_0 and WEBGL_compressed_texture_s3tc_srgb. #Patch Set 6 : WEBGL_compressed_texture_es3_0 is not available on desktop Linux. #
Messages
Total messages: 43 (23 generated)
Description was changed from ========== Port WebGL extension availability tests to the integration test harness. These were accidentally lost during the switch to the new test harness. Convert the expectations to the new format of the test names. The old tests aren't being run anywhere any more and will be deleted. BUG=352807 ========== to ========== Port WebGL extension availability tests to the integration test harness. These were accidentally lost during the switch to the new test harness. Convert the expectations to the new format of the test names. The old tests aren't being run anywhere any more and will be deleted. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + eyaich@chromium.org, nednguyen@google.com, zmo@chromium.org
Emily, Ned, Mo: please review. Thanks. https://codereview.chromium.org/2297673002/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/webgl_conformance_integration_test.py (right): https://codereview.chromium.org/2297673002/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:143: def _RunExtensionCoverageTest(self, test_path, *args): Compare to similar code in webgl_conformance.py.
The CQ bit was checked by kbr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/30 13:11:29, Ken Russell wrote: > Emily, Ned, Mo: please review. Thanks. > > https://codereview.chromium.org/2297673002/diff/1/content/test/gpu/gpu_tests/... > File content/test/gpu/gpu_tests/webgl_conformance_integration_test.py (right): > > https://codereview.chromium.org/2297673002/diff/1/content/test/gpu/gpu_tests/... > content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:143: def > _RunExtensionCoverageTest(self, test_path, *args): > Compare to similar code in webgl_conformance.py. lgtm to fix the fire
On 2016/08/30 13:33:38, nednguyen wrote: > On 2016/08/30 13:11:29, Ken Russell wrote: > > Emily, Ned, Mo: please review. Thanks. > > > > > https://codereview.chromium.org/2297673002/diff/1/content/test/gpu/gpu_tests/... > > File content/test/gpu/gpu_tests/webgl_conformance_integration_test.py (right): > > > > > https://codereview.chromium.org/2297673002/diff/1/content/test/gpu/gpu_tests/... > > content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:143: def > > _RunExtensionCoverageTest(self, test_path, *args): > > Compare to similar code in webgl_conformance.py. > > lgtm to fix the fire lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
lgtm
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, zmo@chromium.org, eyaich@chromium.org Link to the patchset: https://codereview.chromium.org/2297673002/#ps40001 (title: "Skip non-desktop compressed texture extension tests on WebGL2 too.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
Fixed breakage of test expectations due to specification of multiple directories in SetStaticServerDirs by adding URL prefixes to TestExpectations. Filed https://github.com/catapult-project/catapult/issues/2796 about this issue. Tested locally and confirmed that test expectations are working again. Re-CQ'ing.
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, zmo@chromium.org, eyaich@chromium.org Link to the patchset: https://codereview.chromium.org/2297673002/#ps60001 (title: "Add URL prefixes to handle multiple static server dirs.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
CC'ing Kai. Kai, this test verifies the availability of the two new extensions you've been working on; I've conservatively skipped the WEBGL_compressed_texture_s3tc_srgb test but these should both be revisited.
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, zmo@chromium.org, eyaich@chromium.org Link to the patchset: https://codereview.chromium.org/2297673002/#ps80001 (title: "Add WEBGL_compressed_texture_es3_0 and WEBGL_compressed_texture_s3tc_srgb.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, zmo@chromium.org, eyaich@chromium.org Link to the patchset: https://codereview.chromium.org/2297673002/#ps100001 (title: "WEBGL_compressed_texture_es3_0 is not available on desktop Linux.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing to commit, working tree clean
Message was sent while issue was closed.
Description was changed from ========== Port WebGL extension availability tests to the integration test harness. These were accidentally lost during the switch to the new test harness. Convert the expectations to the new format of the test names. The old tests aren't being run anywhere any more and will be deleted. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Port WebGL extension availability tests to the integration test harness. These were accidentally lost during the switch to the new test harness. Convert the expectations to the new format of the test names. The old tests aren't being run anywhere any more and will be deleted. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ce19d57eda179fe9b47d00159eb25bc025712c9b Cr-Commit-Position: refs/heads/master@{#421111} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/ce19d57eda179fe9b47d00159eb25bc025712c9b Cr-Commit-Position: refs/heads/master@{#421111}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2369373003/ by kbr@chromium.org. The reason for reverting is: Seems to have broken wildcard test expectations: http://crbug.com/650711. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
