Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Issue 2378543002: (Reland) Port WebGL extension availability tests to the integration test harness. (Closed)
Patch Set: Skip WebglExtension_WEBGL_compressed_texture_s3tc_srgb on Android too. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 5
6 from gpu_tests.gpu_test_expectations import GpuTestExpectations 6 from gpu_tests.gpu_test_expectations import GpuTestExpectations
7 7
8 # See the GpuTestExpectations class for documentation. 8 # See the GpuTestExpectations class for documentation.
9 9
10 class WebGLConformanceExpectations(GpuTestExpectations): 10 class WebGLConformanceExpectations(GpuTestExpectations):
11 def __init__(self, conformance_path): 11 def __init__(self, conformance_path, url_prefixes=None):
12 self.conformance_path = conformance_path 12 self.conformance_path = conformance_path
13 super(WebGLConformanceExpectations, self).__init__() 13 super(WebGLConformanceExpectations, self).__init__(
14 url_prefixes=url_prefixes)
14 15
15 def Fail(self, pattern, condition=None, bug=None): 16 def Fail(self, pattern, condition=None, bug=None):
16 self.CheckPatternIsValid(pattern) 17 self.CheckPatternIsValid(pattern)
17 GpuTestExpectations.Fail(self, pattern, condition, bug) 18 GpuTestExpectations.Fail(self, pattern, condition, bug)
18 19
19 def Flaky(self, pattern, condition=None, bug=None, max_num_retries=2): 20 def Flaky(self, pattern, condition=None, bug=None, max_num_retries=2):
20 self.CheckPatternIsValid(pattern) 21 self.CheckPatternIsValid(pattern)
21 GpuTestExpectations.Flaky(self, pattern, condition, bug=bug, 22 GpuTestExpectations.Flaky(self, pattern, condition, bug=bug,
22 max_num_retries=max_num_retries) 23 max_num_retries=max_num_retries)
23 24
24 def Skip(self, pattern, condition=None, bug=None): 25 def Skip(self, pattern, condition=None, bug=None):
25 self.CheckPatternIsValid(pattern) 26 self.CheckPatternIsValid(pattern)
26 GpuTestExpectations.Skip(self, pattern, condition, bug) 27 GpuTestExpectations.Skip(self, pattern, condition, bug)
27 28
28 def CheckPatternIsValid(self, pattern): 29 def CheckPatternIsValid(self, pattern):
29 # Look for basic wildcards. 30 # Look for basic wildcards.
30 if not '*' in pattern and not 'WebglExtension.' in pattern: 31 if not '*' in pattern and not 'WebglExtension_' in pattern:
31 full_path = os.path.normpath(os.path.join(self.conformance_path, pattern)) 32 full_path = os.path.normpath(os.path.join(self.conformance_path, pattern))
32 if not os.path.exists(full_path): 33 if not os.path.exists(full_path):
33 raise Exception('The WebGL conformance test path specified in ' + 34 raise Exception('The WebGL conformance test path specified in ' +
34 'expectation does not exist: ' + full_path) 35 'expectation does not exist: ' + full_path)
35 36
36 def SetExpectations(self): 37 def SetExpectations(self):
37 # =================================== 38 # ===================================
38 # Extension availability expectations 39 # Extension availability expectations
39 # =================================== 40 # ===================================
40 # It's expected that not all extensions will be available on all platforms. 41 # It's expected that not all extensions will be available on all platforms.
41 # Having a test listed here is not necessarily a problem. 42 # Having a test listed here is not necessarily a problem.
42 43
43 self.Fail('WebglExtension.EXT_color_buffer_float', 44 self.Fail('WebglExtension_EXT_color_buffer_float',
44 ['win', 'mac']) 45 ['win', 'mac'])
45 self.Fail('WebglExtension.WEBGL_compressed_texture_astc', 46 # Skip these, rather than expect them to fail, to speed up test
47 # execution. The browser is restarted even after expected test
48 # failures.
49 self.Skip('WebglExtension_WEBGL_compressed_texture_astc',
46 ['win', 'mac', 'linux']) 50 ['win', 'mac', 'linux'])
47 self.Fail('WebglExtension.WEBGL_compressed_texture_atc', 51 self.Skip('WebglExtension_WEBGL_compressed_texture_atc',
48 ['win', 'mac', 'linux']) 52 ['win', 'mac', 'linux'])
49 self.Fail('WebglExtension.WEBGL_compressed_texture_etc1', 53 self.Skip('WebglExtension_WEBGL_compressed_texture_etc1',
50 ['mac', 'linux']) 54 ['mac', 'linux'])
51 self.Fail('WebglExtension.WEBGL_compressed_texture_pvrtc', 55 self.Skip('WebglExtension_WEBGL_compressed_texture_pvrtc',
52 ['win', 'mac', 'linux']) 56 ['win', 'mac', 'linux'])
57 self.Skip('WebglExtension_WEBGL_compressed_texture_s3tc_srgb',
58 ['win', 'mac', 'linux', 'android'])
53 59
54 # Extensions not available under D3D9 60 # Extensions not available under D3D9
55 self.Fail('WebglExtension.EXT_disjoint_timer_query', 61 self.Fail('WebglExtension_EXT_disjoint_timer_query',
56 ['win', 'd3d9']) 62 ['win', 'd3d9'])
57 self.Fail('WebglExtension.EXT_sRGB', 63 self.Fail('WebglExtension_EXT_sRGB',
58 ['win', 'd3d9']) 64 ['win', 'd3d9'])
59 self.Fail('WebglExtension.WEBGL_compressed_texture_etc1', 65 self.Fail('WebglExtension_WEBGL_compressed_texture_etc1',
60 ['win', 'd3d9']) 66 ['win', 'd3d9'])
61 67
62 self.Fail('WebglExtension.WEBGL_depth_texture', 68 self.Fail('WebglExtension_WEBGL_depth_texture',
63 ['win', 'amd', 'd3d9']) 69 ['win', 'amd', 'd3d9'])
64 70
65 self.Fail('WebglExtension.WEBGL_draw_buffers', 71 self.Fail('WebglExtension_WEBGL_draw_buffers',
66 ['win', 'd3d9']) 72 ['win', 'd3d9'])
67 73
68 # Android general 74 # Android general
69 self.Fail('WebglExtension.EXT_disjoint_timer_query', 75 self.Fail('WebglExtension_EXT_disjoint_timer_query',
70 ['android']) 76 ['android'])
71 self.Fail('WebglExtension.EXT_frag_depth', 77 self.Fail('WebglExtension_EXT_frag_depth',
72 ['android']) 78 ['android'])
73 self.Fail('WebglExtension.EXT_shader_texture_lod', 79 self.Fail('WebglExtension_EXT_shader_texture_lod',
74 ['android']) 80 ['android'])
75 self.Fail('WebglExtension.WEBGL_compressed_texture_astc', 81 self.Fail('WebglExtension_WEBGL_compressed_texture_astc',
76 ['android']) 82 ['android'])
77 self.Fail('WebglExtension.WEBGL_compressed_texture_pvrtc', 83 self.Fail('WebglExtension_WEBGL_compressed_texture_pvrtc',
78 ['android']) 84 ['android'])
79 self.Fail('WebglExtension.WEBGL_compressed_texture_s3tc', 85 self.Fail('WebglExtension_WEBGL_compressed_texture_s3tc',
80 ['android']) 86 ['android'])
81 self.Fail('WebglExtension.WEBGL_depth_texture', 87 self.Fail('WebglExtension_WEBGL_depth_texture',
82 ['android']) 88 ['android'])
83 self.Fail('WebglExtension.WEBGL_draw_buffers', 89 self.Fail('WebglExtension_WEBGL_draw_buffers',
84 ['android']) 90 ['android'])
85 91
86 # Nexus 5 92 # Nexus 5
87 self.Fail('WebglExtension.OES_texture_float_linear', 93 self.Fail('WebglExtension_OES_texture_float_linear',
88 ['android', ('qualcomm', 'Adreno (TM) 330')]) 94 ['android', ('qualcomm', 'Adreno (TM) 330')])
89 95
96 # Nexus 5X
97 self.Fail('WebglExtension_EXT_sRGB',
98 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)
99
90 # Nexus 6 (Adreno 420) and 6P (Adreno 430) 100 # Nexus 6 (Adreno 420) and 6P (Adreno 430)
91 self.Fail('WebglExtension.EXT_sRGB', 101 self.Fail('WebglExtension_EXT_sRGB',
92 ['android', 102 ['android',
93 ('qualcomm', 'Adreno (TM) 420'), 103 ('qualcomm', 'Adreno (TM) 420'),
94 ('qualcomm', 'Adreno (TM) 430')]) 104 ('qualcomm', 'Adreno (TM) 430')])
95 105
96 # Nexus 9 106 # Nexus 9
97 self.Fail('WebglExtension.WEBGL_compressed_texture_atc', 107 self.Fail('WebglExtension_WEBGL_compressed_texture_atc',
98 ['android', ('nvidia', 'NVIDIA Tegra')]) 108 ['android', ('nvidia', 'NVIDIA Tegra')])
99 109
100 # ======================== 110 # ========================
101 # Conformance expectations 111 # Conformance expectations
102 # ======================== 112 # ========================
103 # Fails on all platforms 113 # Fails on all platforms
104 114
105 # We need to add WebGL 1 check in command buffer that format/type from 115 # We need to add WebGL 1 check in command buffer that format/type from
106 # TexSubImage2D have to match the current texture's. 116 # TexSubImage2D have to match the current texture's.
107 self.Fail('conformance/textures/misc/tex-sub-image-2d-bad-args.html', 117 self.Fail('conformance/textures/misc/tex-sub-image-2d-bad-args.html',
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 # out. Skip it for now until it's fixed and running reliably. 439 # out. Skip it for now until it's fixed and running reliably.
430 self.Skip('conformance/extensions/oes-texture-half-float-with-video.html', 440 self.Skip('conformance/extensions/oes-texture-half-float-with-video.html',
431 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883) 441 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883)
432 self.Fail('conformance/extensions/webgl-compressed-texture-atc.html', 442 self.Fail('conformance/extensions/webgl-compressed-texture-atc.html',
433 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883) 443 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883)
434 self.Fail('conformance/glsl/bugs/sampler-struct-function-arg.html', 444 self.Fail('conformance/glsl/bugs/sampler-struct-function-arg.html',
435 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883) 445 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883)
436 # This test is skipped because it is crashing the GPU process. 446 # This test is skipped because it is crashing the GPU process.
437 self.Skip('conformance/glsl/misc/shader-with-non-reserved-words.html', 447 self.Skip('conformance/glsl/misc/shader-with-non-reserved-words.html',
438 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883) 448 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883)
439 self.Fail('WebglExtension.EXT_sRGB',
440 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)
441 self.Fail('conformance/textures/misc/' + 449 self.Fail('conformance/textures/misc/' +
442 'tex-image-and-sub-image-2d-with-array-buffer-view.html', 450 'tex-image-and-sub-image-2d-with-array-buffer-view.html',
443 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951) 451 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)
444 self.Fail('conformance/textures/canvas/*', 452 self.Fail('conformance/textures/canvas/*',
445 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951) 453 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)
446 self.Fail('conformance/textures/image/*', 454 self.Fail('conformance/textures/image/*',
447 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951) 455 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)
448 self.Fail('conformance/textures/image_bitmap_from_canvas/*', 456 self.Fail('conformance/textures/image_bitmap_from_canvas/*',
449 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951) 457 ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)
450 self.Fail('conformance/textures/image_bitmap_from_blob/*', 458 self.Fail('conformance/textures/image_bitmap_from_blob/*',
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
720 self.Fail('conformance/textures/misc/texture-npot.html', 728 self.Fail('conformance/textures/misc/texture-npot.html',
721 ['chromeos', ('intel', 0xa011)], bug=375554) 729 ['chromeos', ('intel', 0xa011)], bug=375554)
722 self.Fail('conformance/textures/misc/texture-npot-video.html', 730 self.Fail('conformance/textures/misc/texture-npot-video.html',
723 ['chromeos', ('intel', 0xa011)], bug=375554) 731 ['chromeos', ('intel', 0xa011)], bug=375554)
724 self.Fail('conformance/textures/misc/texture-size.html', 732 self.Fail('conformance/textures/misc/texture-size.html',
725 ['chromeos', ('intel', 0xa011)], bug=375554) 733 ['chromeos', ('intel', 0xa011)], bug=375554)
726 self.Fail('conformance/uniforms/gl-uniform-arrays.html', 734 self.Fail('conformance/uniforms/gl-uniform-arrays.html',
727 ['chromeos', ('intel', 0xa011)], bug=375554) 735 ['chromeos', ('intel', 0xa011)], bug=375554)
728 self.Skip('conformance/uniforms/uniform-default-values.html', 736 self.Skip('conformance/uniforms/uniform-default-values.html',
729 ['chromeos', ('intel', 0xa011)], bug=375554) 737 ['chromeos', ('intel', 0xa011)], bug=375554)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698