Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 2377943002: [typedarray] Properly initialize JSTypedArray::length with Smi. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[typedarray] Properly initialize JSTypedArray::length with Smi. Even after https://codereview.chromium.org/2371963002 we still did not always store a Smi into the JSTypedArray::length field, the runtime function %TypedArrayInitializeFromArrayLike was still storing whatever it got from the JavaScript code, which is highly dependent on internal decisions of the ICs and the representation selection in the optimizing compilers, so that's pretty fragile. R=verwaest@chromium.org BUG=chromium:650933 Committed: https://crrev.com/15a449b141bbecd70a3eaa6fba401b74e0810796 Cr-Commit-Position: refs/heads/master@{#39802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/runtime/runtime-typedarray.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-650933.js View 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-09-28 05:23:43 UTC) #1
Toon Verwaest
lgtm
4 years, 2 months ago (2016-09-28 05:30:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377943002/1
4 years, 2 months ago (2016-09-28 05:31:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 05:49:29 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 05:49:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15a449b141bbecd70a3eaa6fba401b74e0810796
Cr-Commit-Position: refs/heads/master@{#39802}

Powered by Google App Engine
This is Rietveld 408576698