Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2380543002: [stubs] Don't unconditionally canonicalize in ChangeFloat64ToTagged. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Don't unconditionally canonicalize in ChangeFloat64ToTagged. Add a CanonicalizationMode to CodeStubAssembler::ChangeFloat64ToTagged, so clients can request Smi canonicalization when desired, but otherwise get Crankshaft/Fullcodegen compatible behavior of just boxing the double into a HeapNumber. R=verwaest@chromium.org BUG=v8:5268 Committed: https://crrev.com/06eef6e6d8199df8317df8469d767092472f3fe0 Cr-Commit-Position: refs/heads/master@{#39804}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -43 lines) Patch
M src/code-stub-assembler.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 2 chunks +62 lines, -42 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
Benedikt Meurer
4 years, 2 months ago (2016-09-28 05:35:42 UTC) #1
Toon Verwaest
lgtm
4 years, 2 months ago (2016-09-28 06:39:49 UTC) #8
Jarin
lgtm
4 years, 2 months ago (2016-09-28 06:40:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380543002/20001
4 years, 2 months ago (2016-09-28 06:40:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 06:42:52 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/06eef6e6d8199df8317df8469d767092472f3fe0 Cr-Commit-Position: refs/heads/master@{#39804}
4 years, 2 months ago (2016-09-28 06:43:09 UTC) #15
Benedikt Meurer
4 years, 2 months ago (2016-09-28 09:03:32 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2373253003/ by bmeurer@chromium.org.

The reason for reverting is: Tanks ai-astar in Kraken pretty badly (some deopt
loop)..

Powered by Google App Engine
This is Rietveld 408576698