Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 2371963002: [crankshaft] TypedArrayInitialize: force length to be a Smi (Closed)

Created:
4 years, 2 months ago by Jakob Kummerow
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] TypedArrayInitialize: force length to be a Smi BUG=chromium:650404 Committed: https://crrev.com/142f9dfcade6e5010468cb6f55ef9512c1993b27 Cr-Commit-Position: refs/heads/master@{#39744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-650404.js View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
adamk
lgtm
4 years, 2 months ago (2016-09-26 21:38:53 UTC) #4
Jakob Kummerow
Thanks, landing.
4 years, 2 months ago (2016-09-26 22:57:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371963002/1
4 years, 2 months ago (2016-09-26 22:57:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 23:00:35 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/142f9dfcade6e5010468cb6f55ef9512c1993b27 Cr-Commit-Position: refs/heads/master@{#39744}
4 years, 2 months ago (2016-09-26 23:00:51 UTC) #12
Benedikt Meurer
4 years, 2 months ago (2016-09-27 03:58:20 UTC) #14
Message was sent while issue was closed.
Awesome, thanks a lot, Jakob!

Powered by Google App Engine
This is Rietveld 408576698