|
|
Created:
4 years, 3 months ago by Benedikt Meurer Modified:
4 years, 2 months ago Reviewers:
Jarin CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] ChangeFloat64ToTagged shouldn't canonicalize.
This matches current Crankshaft/fullcodegen behavior more closely and
thus reduces the chances that we run into unnecessary polymorphism due
to the field representation tracking in our object model.
Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi
if possible (otherwise we tank the regexp benchmark in Octane).
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg
R=jarin@chromium.org
BUG=v8:5267
Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca99c0ef
Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73
Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd
Committed: https://crrev.com/19b3943607521f63fe44774ef36becf747cb818e
Cr-Original-Original-Commit-Position: refs/heads/master@{#39692}
Cr-Original-Commit-Position: refs/heads/master@{#39748}
Cr-Commit-Position: refs/heads/master@{#39803}
Patch Set 1 #Patch Set 2 : Fix %SetAllocationTimeout argument assumptions. #Patch Set 3 : RegExp mitigation #Patch Set 4 : REBASE onto https://codereview.chromium.org/2371963002 #Patch Set 5 : Enforce Smi representation for JSTypedArray::length in %TypedArrayInitializeFromArrayLike. #Patch Set 6 : Fix the stub cache tests. #Patch Set 7 : REBASE #
Depends on Patchset: Messages
Total messages: 110 (85 generated)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_win64_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_win_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/6a939714e991ebf10d56ddbd2869325cca99c0ef Cr-Commit-Position: refs/heads/master@{#39655} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6a939714e991ebf10d56ddbd2869325cca99c0ef Cr-Commit-Position: refs/heads/master@{#39655}
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/6a939714e991ebf10d56ddbd2869325cca99c0ef Cr-Commit-Position: refs/heads/master@{#39655} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 6a939714e991ebf10d56ddbd2869325cca99c0ef (presubmit successful).
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2358123007/ by bmeurer@chromium.org. The reason for reverting is: Causes tree breakage: https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/12916/steps....
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... ==========
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2367593003/#ps80001 (title: "RegExp mitigation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Cr-Commit-Position: refs/heads/master@{#39692} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Cr-Commit-Position: refs/heads/master@{#39692}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2367963002/ by bmeurer@chromium.org. The reason for reverting is: Failing on the main waterfall again (again for typedarray, even tho it passed trybots?): https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/11515/steps....
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Cr-Commit-Position: refs/heads/master@{#39692} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Cr-Commit-Position: refs/heads/master@{#39692} ==========
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2367593003/#ps100001 (title: "REBASE onto https://codereview.chromium.org/2371963002")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Cr-Commit-Position: refs/heads/master@{#39692} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Cr-Commit-Position: refs/heads/master@{#39692} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Cr-Commit-Position: refs/heads/master@{#39692} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Commit-Position: refs/heads/master@{#39748}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2365353006/ by bmeurer@chromium.org. The reason for reverting is: Still blows up on the main waterfall even after Jakob's fix: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/11557/steps... https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/11557/steps... https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/12982/steps....
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac64_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac64_dbg/builds/113)
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). Also ensure that the JSTypedArray::length field is properly initialized with a Smi always. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2367593003/#ps200001 (title: "Enforce Smi representation for JSTypedArray::length in %TypedArrayInitializeFromArrayLike.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac64_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac64_dbg/builds/114)
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). Also ensure that the JSTypedArray::length field is properly initialized with a Smi always. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). Also ensure that the JSTypedArray::length field is properly initialized with a Smi always. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13590) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2367593003/#ps220001 (title: "Blacklist SecondaryStubCache test for --turbo and --always-opt.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13594) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). Also ensure that the JSTypedArray::length field is properly initialized with a Smi always. R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). Also ensure that the JSTypedArray::length field is properly initialized with a Smi always. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #13 (id:240001) has been deleted
Patchset #12 (id:220001) has been deleted
Patchset #7 (id:120001) has been deleted
Patchset #4 (id:60001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #5 (id:140001) has been deleted
Patchset #5 (id:160001) has been deleted
Patchset #5 (id:180001) has been deleted
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2367593003/#ps260001 (title: "Fix the stub cache tests.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). Also ensure that the JSTypedArray::length field is properly initialized with a Smi always. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2367593003/#ps280001 (title: "REBASE")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ==========
Message was sent while issue was closed.
Committed patchset #7 (id:280001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Original-Commit-Position: refs/heads/master@{#39692} Cr-Commit-Position: refs/heads/master@{#39748} ========== to ========== [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca9... Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Committed: https://crrev.com/19b3943607521f63fe44774ef36becf747cb818e Cr-Original-Original-Commit-Position: refs/heads/master@{#39692} Cr-Original-Commit-Position: refs/heads/master@{#39748} Cr-Commit-Position: refs/heads/master@{#39803} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/19b3943607521f63fe44774ef36becf747cb818e Cr-Commit-Position: refs/heads/master@{#39803} |