Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2367593003: [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] ChangeFloat64ToTagged shouldn't canonicalize. This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca99c0ef Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Committed: https://crrev.com/19b3943607521f63fe44774ef36becf747cb818e Cr-Original-Original-Commit-Position: refs/heads/master@{#39692} Cr-Original-Commit-Position: refs/heads/master@{#39748} Cr-Commit-Position: refs/heads/master@{#39803}

Patch Set 1 #

Patch Set 2 : Fix %SetAllocationTimeout argument assumptions. #

Patch Set 3 : RegExp mitigation #

Patch Set 4 : REBASE onto https://codereview.chromium.org/2371963002 #

Patch Set 5 : Enforce Smi representation for JSTypedArray::length in %TypedArrayInitializeFromArrayLike. #

Patch Set 6 : Fix the stub cache tests. #

Patch Set 7 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -147 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 2 3 4 1 chunk +1 line, -68 lines 0 comments Download
M src/compiler/representation-change.cc View 1 2 4 2 chunks +2 lines, -8 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 4 chunks +2 lines, -27 lines 0 comments Download
M src/js/regexp.js View 1 2 3 4 1 chunk +10 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 2 6 chunks +25 lines, -39 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 110 (85 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-23 05:14:18 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-09-23 08:35:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/40001
4 years, 3 months ago (2016-09-23 10:28:55 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/40001
4 years, 3 months ago (2016-09-23 10:31:47 UTC) #23
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6a939714e991ebf10d56ddbd2869325cca99c0ef Cr-Commit-Position: refs/heads/master@{#39655}
4 years, 3 months ago (2016-09-23 10:37:37 UTC) #25
Benedikt Meurer
Committed patchset #3 (id:40001) manually as 6a939714e991ebf10d56ddbd2869325cca99c0ef (presubmit successful).
4 years, 3 months ago (2016-09-23 10:37:47 UTC) #27
Benedikt Meurer
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2358123007/ by bmeurer@chromium.org. ...
4 years, 3 months ago (2016-09-23 11:23:32 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/80001
4 years, 3 months ago (2016-09-23 19:14:38 UTC) #41
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-23 19:27:00 UTC) #43
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Cr-Commit-Position: refs/heads/master@{#39692}
4 years, 3 months ago (2016-09-23 19:27:26 UTC) #45
Benedikt Meurer
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2367963002/ by bmeurer@chromium.org. ...
4 years, 3 months ago (2016-09-23 20:16:27 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/100001
4 years, 2 months ago (2016-09-27 04:04:18 UTC) #50
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-09-27 04:47:35 UTC) #52
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Cr-Commit-Position: refs/heads/master@{#39748}
4 years, 2 months ago (2016-09-27 04:47:48 UTC) #54
Benedikt Meurer
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2365353006/ by bmeurer@chromium.org. ...
4 years, 2 months ago (2016-09-27 05:10:29 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/200001
4 years, 2 months ago (2016-09-27 17:22:29 UTC) #69
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac64_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac64_dbg/builds/114)
4 years, 2 months ago (2016-09-27 17:39:55 UTC) #71
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/200001
4 years, 2 months ago (2016-09-27 17:51:45 UTC) #74
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13590) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-09-27 18:28:10 UTC) #76
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/220001
4 years, 2 months ago (2016-09-27 18:35:21 UTC) #79
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13594) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-09-27 19:12:37 UTC) #81
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/260001
4 years, 2 months ago (2016-09-28 04:48:13 UTC) #98
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367593003/280001
4 years, 2 months ago (2016-09-28 05:50:19 UTC) #106
commit-bot: I haz the power
Committed patchset #7 (id:280001)
4 years, 2 months ago (2016-09-28 06:07:48 UTC) #108
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 06:08:08 UTC) #110
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/19b3943607521f63fe44774ef36becf747cb818e
Cr-Commit-Position: refs/heads/master@{#39803}

Powered by Google App Engine
This is Rietveld 408576698