Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2377733002: Subzero, MIPS32: DIVU instruction encoding (Closed)

Created:
4 years, 2 months ago by obucinac
Modified:
4 years, 2 months ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/IceAssemblerMIPS32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceAssemblerMIPS32.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/IceInstMIPS32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInstMIPS32.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
obucinac
4 years, 2 months ago (2016-09-27 19:59:46 UTC) #3
Jim Stichnoth
LGTM. This looks fine, but in the future it would be better to create or ...
4 years, 2 months ago (2016-09-28 03:27:23 UTC) #4
Jim Stichnoth
4 years, 2 months ago (2016-09-28 03:38:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6163c62fdaca2c1f192afb0ce1da96daf9e53306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698