Remove content_settings_client.h abstraction which isn't used

Remove content_settings_client.h abstraction which isn't used.

This was added in r299090 but the bugs said componentization is finished and it wasn't used.

BUG=387075, 384873, 393248
Committed: https://crrev.com/4433180c92c4d0e62dc73b535911cedba09b1004
Cr-Commit-Position: refs/heads/master@{#422111}

[jam, 2016-09-30 00:08:05]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 00:08:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-30 00:10:16]

Description was changed from

==========
Remove content_settings_client.h abstraction which isn't used
==========

to

==========
Remove content_settings_client.h abstraction which isn't used.

This was added in r299090 but the bugs said componentization is finished and it
wasn't used.
==========

[jam, 2016-09-30 00:10:16]

jam@chromium.org changed reviewers:
+ vabr@chromium.org

[jam, 2016-09-30 00:10:32]

Description was changed from

==========
Remove content_settings_client.h abstraction which isn't used.

This was added in r299090 but the bugs said componentization is finished and it
wasn't used.
==========

to

==========
Remove content_settings_client.h abstraction which isn't used.

This was added in r299090 but the bugs said componentization is finished and it
wasn't used.

BUG=387075, 384873, 393248
==========

[commit-bot: I haz the power, 2016-09-30 01:48:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 01:48:51]

Dry run: This issue passed the CQ dry run.

[jam, 2016-09-30 03:46:46]

actually, I find a bunch of changes in the bugs that were all preparing for
componentization that didn't appear to happen.

can you please undo the other changes that aren't now necessary?

i.e.
https://codereview.chromium.org/678023002
https://codereview.chromium.org/798923003
https://codereview.chromium.org/640733002
https://codereview.chromium.org/588583002
look like they're not needed?

[vabr (Chromium), 2016-09-30 11:12:12]

On 2016/09/30 03:46:46, jam wrote:
> actually, I find a bunch of changes in the bugs that were all preparing for
> componentization that didn't appear to happen.
> 
> can you please undo the other changes that aren't now necessary?
> 
> i.e.
> https://codereview.chromium.org/678023002
> https://codereview.chromium.org/798923003
> https://codereview.chromium.org/640733002
> https://codereview.chromium.org/588583002
> look like they're not needed?

Thanks for catching this, jam@. I will look into removing the unused changes
now.

Cheers,
Vaclav

[vabr (Chromium), 2016-09-30 12:16:05]

And this change LGTM.

[jam, 2016-09-30 14:51:09]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-09-30 14:51:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 14:57:16]

Description was changed from

==========
Remove content_settings_client.h abstraction which isn't used.

This was added in r299090 but the bugs said componentization is finished and it
wasn't used.

BUG=387075, 384873, 393248
==========

to

==========
Remove content_settings_client.h abstraction which isn't used.

This was added in r299090 but the bugs said componentization is finished and it
wasn't used.

BUG=387075, 384873, 393248
==========

[commit-bot: I haz the power, 2016-09-30 14:57:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-30 14:59:49]

Description was changed from

==========
Remove content_settings_client.h abstraction which isn't used.

This was added in r299090 but the bugs said componentization is finished and it
wasn't used.

BUG=387075, 384873, 393248
==========

to

==========
Remove content_settings_client.h abstraction which isn't used.

This was added in r299090 but the bugs said componentization is finished and it
wasn't used.

BUG=387075, 384873, 393248

Committed: https://crrev.com/4433180c92c4d0e62dc73b535911cedba09b1004
Cr-Commit-Position: refs/heads/master@{#422111}
==========

[commit-bot: I haz the power, 2016-09-30 14:59:50]

Patchset 1 (id:??) landed as
https://crrev.com/4433180c92c4d0e62dc73b535911cedba09b1004
Cr-Commit-Position: refs/heads/master@{#422111}

[vabr (Chromium), 2016-09-30 16:12:15]

Hi jam@,

> https://codereview.chromium.org/798923003
This is handled by https://codereview.chromium.org/2387613002/.

> https://codereview.chromium.org/640733002
> https://codereview.chromium.org/588583002
These two are handled by https://codereview.chromium.org/2380943004/ (will send
out for review once the bots are happy).

> https://codereview.chromium.org/678023002
This one actually sounds like a simplification of dependencies valuable on its
own, and we did not have to pay for it with an extra interface class or
anything. So I propose not to revert this one. WDYT?

Cheers,
Vaclav