Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 640733002: Move local_shared_objects_counter.h to content_settings component (Closed)

Created:
6 years, 2 months ago by vabr (Chromium)
Modified:
6 years, 2 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move local_shared_objects_counter.h to content_settings component This is just a simple file move, no other changes. It was meant to be bundled with other moves, but it blocks a non-move CL of mine, therefore moving now. BUG=384873 Committed: https://crrev.com/4856559a13b5bc030d09c7ff385014528823d1f8 Cr-Commit-Position: refs/heads/master@{#298708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M chrome/browser/content_settings/local_shared_objects_container.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/content_settings/local_shared_objects_counter.h View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + components/content_settings/core/browser/local_shared_objects_counter.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vabr (Chromium)
Hi Markus, PTAL, this is just a file move. Cheers, Vaclav
6 years, 2 months ago (2014-10-08 13:50:05 UTC) #2
vabr (Chromium)
Hi Markus, PTAL, this is just a file move. Cheers, Vaclav
6 years, 2 months ago (2014-10-08 13:50:13 UTC) #3
markusheintz_
On 2014/10/08 13:50:13, vabr (Chromium) wrote: > Hi Markus, > > PTAL, this is just ...
6 years, 2 months ago (2014-10-08 14:15:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640733002/1
6 years, 2 months ago (2014-10-08 14:20:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 94a19eed779bcee4bd9dc65d20dcfd3d1157710b
6 years, 2 months ago (2014-10-08 15:06:10 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 15:06:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4856559a13b5bc030d09c7ff385014528823d1f8
Cr-Commit-Position: refs/heads/master@{#298708}

Powered by Google App Engine
This is Rietveld 408576698