Make chrome/renderer/content_settings_observer.cc depend on //components/contents_settings for IPC

Make chrome/renderer/content_settings_observer.cc depend on //components/contents_settings for IPC

In preparation for moving chrome/renderer/content_settings_observer.cc into //components/contents_settings, this CL moves all IPC messages used in that file to a separate IPC declaration header in //components/contents_settings.

The main parts of the change:
* separating messages from chrome/common/render_messages.h to newly created components/content_settings/content/common/content_settings_messages.h
* adding the support files in components/content_settings/content/common/
* extending the filter in chrome/browser/renderer_host/chrome_render_message_filter.cc to catch content settings IPC
* and, of course, removing #include "chrome/common/render_messages.h" from content_settings_observer.cc

The rest is mostly adding #includes and mechanical changes.

BUG=384874, 387075
Committed: https://crrev.com/fc325fa0fbd5ad4e45791376c1a85e8781a89d27
Cr-Commit-Position: refs/heads/master@{#324644}

[vabr (Chromium), 2014-12-15 13:00:04]

Patchset #1 (id:1) has been deleted

[vabr (Chromium), 2015-04-08 15:56:05]

Patchset #1 (id:20001) has been deleted

[vabr (Chromium), 2015-04-08 15:56:13]

Patchset #1 (id:40001) has been deleted

[vabr (Chromium), 2015-04-08 15:56:20]

Patchset #1 (id:60001) has been deleted

[vabr (Chromium), 2015-04-08 15:56:31]

Patchset #1 (id:80001) has been deleted

[vabr (Chromium), 2015-04-08 16:04:11]

vabr@chromium.org changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[vabr (Chromium), 2015-04-08 16:04:12]

Hi Mike and Jochen!

Mike: please do an OWNERS review for the IPC-headers changes. The messages are
only moved, not added/dropped/modified.

Jochen: both as the OWNER of content settings, and the whole //chrome, could you
please review this?

Thanks!
Vaclav

[Mike West, 2015-04-09 05:03:20]

Moving the IPC messages to the new component LGTM.

[jochen (gone - plz use gerrit), 2015-04-09 14:43:50]

i'm surprised you don't need to include the header from
chrome/common/all_messages.h

it would also be nice if the components/content_settings/ directories would
disallow including each other, and you had to explicitly add DEPS entries

[vabr (Chromium), 2015-04-09 17:23:54]

vabr@chromium.org changed reviewers:
+ tsepez@chromium.org

[vabr (Chromium), 2015-04-09 17:23:55]

Hi Tom,
Do changes in tools/ipc_fuzzer/message_lib/* look good to you? The new IPC
messages were included through chrome/common/render_messages.h before.


Thanks, Jochen!
Responses inline.

On 2015/04/09 14:43:50, jochen wrote:
> i'm surprised you don't need to include the header from
> chrome/common/all_messages.h

There do not seem to be any other components headers included in there. However,
chrome/common/all_messages.h itself is only used in ipc_fuzzer, and the
all_messages.h of ipc_fuzzer does include components headers. Following the IPC
header from components/autofill, I just added the new header there. WDYT?

> 
> it would also be nice if the components/content_settings/ directories would
> disallow including each other, and you had to explicitly add DEPS entries
Done. Please let me know if you meant something else.

Cheers,
Vaclav

[Tom Sepez, 2015-04-09 18:02:41]

On 2015/04/09 17:23:55, vabr (Chromium) wrote:
> Hi Tom,
> Do changes in tools/ipc_fuzzer/message_lib/* look good to you? The new IPC
> messages were included through chrome/common/render_messages.h before.
> 
> 
> Thanks, Jochen!
> Responses inline.
> 
> On 2015/04/09 14:43:50, jochen wrote:
> > i'm surprised you don't need to include the header from
> > chrome/common/all_messages.h
> 
> There do not seem to be any other components headers included in there.
However,
> chrome/common/all_messages.h itself is only used in ipc_fuzzer, and the
> all_messages.h of ipc_fuzzer does include components headers. Following the
IPC
> header from components/autofill, I just added the new header there. WDYT?
> 
> > 
> > it would also be nice if the components/content_settings/ directories would
> > disallow including each other, and you had to explicitly add DEPS entries
> Done. Please let me know if you meant something else.
> 
> Cheers,
> Vaclav
Please check that this builds with:
  GYP_DEFINES='enable_ipc_fuzzer=1'; build/gyp_chromium
  ninja -C out/Debug ipc_fuzzer_all

[Tom Sepez, 2015-04-09 18:06:06]

> Please check that this builds with:
>   GYP_DEFINES='enable_ipc_fuzzer=1'; build/gyp_chromium
>   ninja -C out/Debug ipc_fuzzer_all
LGTM once you try the above steps.  Thanks.

[Tom Sepez, 2015-04-09 19:09:00]

On 2015/04/09 18:06:06, Tom Sepez wrote:
> > Please check that this builds with:
> >   GYP_DEFINES='enable_ipc_fuzzer=1'; build/gyp_chromium
> >   ninja -C out/Debug ipc_fuzzer_all
> LGTM once you try the above steps.  Thanks.
And there's a typo in the above steps (stray ;). Lets try again:

GYP_DEFINES='enable_ipc_fuzzer=1' build/gyp_chromium
ninja -C out/Debug ipc_fuzzer_all

[vabr (Chromium), 2015-04-10 07:28:26]

Thanks, Tom, for the compilation instructions.
It failed, and I fixed that in patch set 5. Please have another look.

Hi Jochen, my response to your comments is in
https://codereview.chromium.org/798923003/#msg11 above (just to help you
navigate the growing conversation list here :)).

Cheers,
Vaclav

[vabr (Chromium), 2015-04-10 07:30:52]

Tom, I just realised I also need your approval for ipc/:

Could you please also additionally review the following?
* ipc/ipc_message_start.h
* adding ipc to components/content_settings/content/DEPS

Thanks!
Vaclav

[jochen (gone - plz use gerrit), 2015-04-10 12:19:45]

lgtm

[Tom Sepez, 2015-04-10 16:07:02]

LGTM++

[vabr (Chromium), 2015-04-10 16:19:54]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2015-04-10 16:19:54]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/798923003/#ps170001
(title: "Fix fuzzer compilation")

[commit-bot: I haz the power, 2015-04-10 16:20:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/798923003/170001

[commit-bot: I haz the power, 2015-04-10 16:25:10]

Committed patchset #5 (id:170001)

[commit-bot: I haz the power, 2015-04-10 16:26:00]

Patchset 5 (id:??) landed as
https://crrev.com/fc325fa0fbd5ad4e45791376c1a85e8781a89d27
Cr-Commit-Position: refs/heads/master@{#324644}