LocalSharedObjectsContainer: Separate object counting in an interface

LocalSharedObjectsContainer: Separate object counting in an interface

This CL separates the part of LocalSharedObjectsContainer which is to be componentised into an interface, and keeps the LSOC itself an implementation detail of TabSpecificContentSettings (to be moved to the embedding client at a later point).

More design details here: https://docs.google.com/a/google.com/document/d/1rQ9PMCPL6wHh-QjaZWOBcaYXQgbCka7unSsciQ52qOs/edit#heading=h.hid3xtn12izy

BUG=384873
Committed: https://crrev.com/d5e30cde9d0c724f221101f0ca77f54f30794c59
Cr-Commit-Position: refs/heads/master@{#297802}

[vabr (Chromium), 2014-09-19 14:26:10]

vabr@chromium.org changed reviewers:
+ markusheintz@chromium.org

[vabr (Chromium), 2014-09-19 14:27:49]

Hi Markus,

Could you please have a look?

I'm also happy to talk in person, if you want me to explain more. Once you are
OK with this, I'll loop in the OWNERS of the rest.

Cheers,
Vaclav

[vabr (Chromium), 2014-09-23 07:28:53]

Hi Markus,

A friendly ping. :)

On 2014/09/19 14:27:49, vabr (Chromium) wrote:
> Hi Markus,
> 
> Could you please have a look?
> 
> I'm also happy to talk in person, if you want me to explain more. Once you are
> OK with this, I'll loop in the OWNERS of the rest.
> 
> Cheers,
> Vaclav

[markusheintz_, 2014-09-23 17:55:35]

On 2014/09/23 07:28:53, vabr (Chromium) wrote:
> Hi Markus,
> 
> A friendly ping. :)
> 
> On 2014/09/19 14:27:49, vabr (Chromium) wrote:
> > Hi Markus,
> > 
> > Could you please have a look?
> > 
> > I'm also happy to talk in person, if you want me to explain more. Once you
are
> > OK with this, I'll loop in the OWNERS of the rest.
> > 
> > Cheers,
> > Vaclav

sry for the delay taking a look tomorrow.

[markusheintz_, 2014-10-01 11:12:07]

LGTM. Thanks

https://codereview.chromium.org/588583002/diff/1/chrome/browser/content_setti...
File chrome/browser/content_settings/tab_specific_content_settings.h (right):

https://codereview.chromium.org/588583002/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/tab_specific_content_settings.h:268: const
LocalSharedObjectsCounter& blocked_local_shared_objects() const {
nit: pls add an empty line above

https://codereview.chromium.org/588583002/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/tab_specific_content_settings.h:277:
scoped_ptr<CookiesTreeModel> CreateBlockedCookiesTreeModel() const {
nit: pls add an empty line above

[vabr (Chromium), 2014-10-01 15:25:47]

vabr@chromium.org changed reviewers:
+ pkasting@chromium.org

[vabr (Chromium), 2014-10-01 15:25:48]

Thanks, Markus, comments addressed.

Peter,
Could you please review these 3 files?
chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm
chrome/browser/ui/views/collected_cookies_views.cc
chrome/browser/ui/webui/options/website_settings_handler.h

Thanks!
Vaclav

https://codereview.chromium.org/588583002/diff/1/chrome/browser/content_setti...
File chrome/browser/content_settings/tab_specific_content_settings.h (right):

https://codereview.chromium.org/588583002/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/tab_specific_content_settings.h:268: const
LocalSharedObjectsCounter& blocked_local_shared_objects() const {
On 2014/10/01 11:12:07, markusheintz_ wrote:
> nit: pls add an empty line above

Done.

https://codereview.chromium.org/588583002/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/tab_specific_content_settings.h:277:
scoped_ptr<CookiesTreeModel> CreateBlockedCookiesTreeModel() const {
On 2014/10/01 11:12:07, markusheintz_ wrote:
> nit: pls add an empty line above

Done.

[Peter Kasting, 2014-10-01 18:07:03]

LGTM

[vabr (Chromium), 2014-10-02 10:42:45]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2014-10-02 10:44:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588583002/40001

[commit-bot: I haz the power, 2014-10-02 11:06:11]

Committed patchset #3 (id:40001) as a5727f37e6039936b6f0155c55bd214dc1aba308

[commit-bot: I haz the power, 2014-10-02 11:08:07]

Patchset 3 (id:??) landed as
https://crrev.com/d5e30cde9d0c724f221101f0ca77f54f30794c59
Cr-Commit-Position: refs/heads/master@{#297802}