Baseline of hwcplus package taken from KitKat AOSP.

Baseline of hwcplus package taken from KitKat AOSP.

BUG=361139
TBR=fjhenigman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264633

[rjkroege, 2014-04-16 18:59:56]

AOSP baseline

[fjhenigman, 2014-04-16 23:05:35]

On 2014/04/16 18:59:56, rjkroege wrote:
> AOSP baseline

Very close to what I was doing so no problem for me.  We agreed we want a
baseline, then my changes on top, so makes sense to land this.
Two things:
1. bitops.h doesn't seem to be necessary.
2. Are you planning to use hardware.c?  I was thinking the platform specific
packages would provide libhardware along with the HAL modules.  Or is
libhardware by definition supposed to platform independent?  I know of at least
one thing in there which needs changing: the default paths to search for the HAL
libraries.  We also raised the possibility of rolling our own HAL loader.  I'd
ditch this too unless you have a use for it.

[rjkroege, 2014-04-17 16:03:49]

On 2014/04/16 23:05:35, fjhenigman wrote:
> On 2014/04/16 18:59:56, rjkroege wrote:
> > AOSP baseline
> 
> Very close to what I was doing so no problem for me.  

awesome.

> We agreed we want a
> baseline, then my changes on top, so makes sense to land this.
> Two things:
> 1. bitops.h doesn't seem to be necessary.

true. removed.

> 2. Are you planning to use hardware.c?  I was thinking the platform specific
> packages would provide libhardware along with the HAL modules.  Or is
> libhardware by definition supposed to platform independent?  I know of at
least
> one thing in there which needs changing: the default paths to search for the
HAL
> libraries.  We also raised the possibility of rolling our own HAL loader.  I'd
> ditch this too unless you have a use for it.

I strongly prefer to have the functionality that implements module loading be in
the Chrome binary. So providing that functionality in this package is desirable.

I have no strong opinion as to how we implement this. We need to not use base
here so starting with hardware.c seems reasonable. My preference would be to
leave it in on that basis.

[rjkroege, 2014-04-17 17:58:34]

The CQ bit was checked by rjkroege@chromium.org

[commit-bot: I haz the power, 2014-04-17 17:59:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjkroege@chromium.org/237533013/20001

[commit-bot: I haz the power, 2014-04-17 21:05:23]

Change committed as 264633