Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2374083003: Revert of ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES. (Closed)

Created:
4 years, 2 months ago by Geoff Lang
Modified:
4 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES. (patchset #1 id:1 of https://codereview.chromium.org/2374123002/ ) Reason for revert: Flaky results in WebglConformance_conformance_extensions_oes_texture_half_float on win_optional_gpu_tests_rel. Original issue's description: > ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES. > > BUG=607283 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa > Cr-Commit-Position: refs/heads/master@{#421614} TBR=zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607283 Committed: https://crrev.com/fc240d705399238dbf29e20ff34735b81cc51cb5 Cr-Commit-Position: refs/heads/master@{#421661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Geoff Lang
Created Revert of ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.
4 years, 2 months ago (2016-09-28 22:27:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374083003/1
4 years, 2 months ago (2016-09-28 22:27:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 22:28:20 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 22:30:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc240d705399238dbf29e20ff34735b81cc51cb5
Cr-Commit-Position: refs/heads/master@{#421661}

Powered by Google App Engine
This is Rietveld 408576698