gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 2374083003: Revert of ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2374083003: Revert of ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index 1cb498ff91bdbff470a87428a3b1d550fcfb00f1..fad05fe6ff9d4458c167d167cc854ca3fcf09400 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -10868,7 +10868,7 @@

"format and type incompatible with the current read framebuffer");

return error::kNoError;

}

- if (type == GL_HALF_FLOAT_OES && !gl_version_info().is_es) {

+ if (type == GL_HALF_FLOAT_OES && !gl_version_info().is_es2) {

type = GL_HALF_FLOAT;

}

if (width == 0 || height == 0) {

« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance_expectations.py ('k') | no next file » | no next file with comments »