ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Committed: https://crrev.com/860001120ed3a441f827f8a9850391903ddfaf0a
Cr-Original-Commit-Position: refs/heads/master@{#421614}
Cr-Commit-Position: refs/heads/master@{#421828}

[Geoff Lang, 2016-09-28 18:28:10]

Description was changed from

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
==========

to

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-09-28 18:28:10]

Description was changed from

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-09-28 18:28:46]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 18:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2016-09-28 19:28:00]

Description was changed from

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-09-28 19:28:00]

geofflang@chromium.org changed reviewers:
+ zmo@chromium.org

[Geoff Lang, 2016-09-28 19:28:11]

PTAL

[commit-bot: I haz the power, 2016-09-28 19:28:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 19:28:39]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-09-28 19:34:31]

However, HALF_FLOAT does not exist on ES2, so it will fail on non-ANGLE ES2
drivers.

[Geoff Lang, 2016-09-28 19:41:56]

On 2016/09/28 19:34:31, Zhenyao Mo wrote:
> However, HALF_FLOAT does not exist on ES2, so it will fail on non-ANGLE ES2
> drivers.

That logic is preserved.  The problem is that we were converting HALF_FLOAT_OES
to HALF_FLOAT in ES3 which is not allowed unless it's returned as the
implementation read type.

[Zhenyao Mo, 2016-09-28 19:48:47]

On 2016/09/28 19:41:56, Geoff Lang wrote:
> On 2016/09/28 19:34:31, Zhenyao Mo wrote:
> > However, HALF_FLOAT does not exist on ES2, so it will fail on non-ANGLE ES2
> > drivers.
> 
> That logic is preserved.  The problem is that we were converting
HALF_FLOAT_OES
> to HALF_FLOAT in ES3 which is not allowed unless it's returned as the
> implementation read type.

Apparently my brain is still muddy.

LGTM

[Geoff Lang, 2016-09-28 19:50:45]

On 2016/09/28 19:48:47, Zhenyao Mo wrote:
> On 2016/09/28 19:41:56, Geoff Lang wrote:
> > On 2016/09/28 19:34:31, Zhenyao Mo wrote:
> > > However, HALF_FLOAT does not exist on ES2, so it will fail on non-ANGLE
ES2
> > > drivers.
> > 
> > That logic is preserved.  The problem is that we were converting
> HALF_FLOAT_OES
> > to HALF_FLOAT in ES3 which is not allowed unless it's returned as the
> > implementation read type.
> 
> Apparently my brain is still muddy.
> 
> LGTM

NP, glad you're starting to feel better!

[Geoff Lang, 2016-09-28 19:50:51]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2016-09-28 19:51:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 19:57:07]

Description was changed from

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-28 19:57:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-28 19:59:31]

Description was changed from

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Cr-Commit-Position: refs/heads/master@{#421614}
==========

[commit-bot: I haz the power, 2016-09-28 19:59:32]

Patchset 1 (id:??) landed as
https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Cr-Commit-Position: refs/heads/master@{#421614}

[Geoff Lang, 2016-09-28 22:27:01]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2374083003/ by geofflang@chromium.org.

The reason for reverting is: Flaky results in
WebglConformance_conformance_extensions_oes_texture_half_float on
win_optional_gpu_tests_rel..

[Geoff Lang, 2016-09-29 15:33:59]

Description was changed from

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Cr-Commit-Position: refs/heads/master@{#421614}
==========

to

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Cr-Commit-Position: refs/heads/master@{#421614}
==========

[Geoff Lang, 2016-09-29 15:34:05]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2016-09-29 15:34:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 15:39:53]

Description was changed from

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Cr-Commit-Position: refs/heads/master@{#421614}
==========

to

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Cr-Commit-Position: refs/heads/master@{#421614}
==========

[commit-bot: I haz the power, 2016-09-29 15:39:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 15:44:05]

Description was changed from

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Cr-Commit-Position: refs/heads/master@{#421614}
==========

to

==========
ReadPixels with GL_HALF_FLOAT_OES when targetting all versions of ES.

BUG=607283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2d1b397c9a057651edbd3ef70266cb0727671baa
Committed: https://crrev.com/860001120ed3a441f827f8a9850391903ddfaf0a
Cr-Original-Commit-Position: refs/heads/master@{#421614}
Cr-Commit-Position: refs/heads/master@{#421828}
==========

[commit-bot: I haz the power, 2016-09-29 15:44:06]

Patchset 1 (id:??) landed as
https://crrev.com/860001120ed3a441f827f8a9850391903ddfaf0a
Cr-Commit-Position: refs/heads/master@{#421828}