Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2373133002: [Findit] Update found_project and found_components. (Closed)

Created:
4 years, 2 months ago by Sharu Jiang
Modified:
4 years, 2 months ago
Reviewers:
chanli, stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Update found_project and found_components. BUG=644411 Committed: https://chromium.googlesource.com/infra/infra/+/9191cc8075241cd6f90bb5382c01999d8cbe0ed9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comments. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M appengine/findit/crash/findit_for_chromecrash.py View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M appengine/findit/crash/test/findit_for_chromecrash_test.py View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Sharu Jiang
PTAL :)
4 years, 2 months ago (2016-09-27 21:49:36 UTC) #5
Sharu Jiang
PTAL :)
4 years, 2 months ago (2016-09-27 21:49:38 UTC) #6
stgao
lgtm if clients are OK with the change to "found". https://codereview.chromium.org/2373133002/diff/40001/appengine/findit/crash/findit_for_chromecrash.py File appengine/findit/crash/findit_for_chromecrash.py (right): https://codereview.chromium.org/2373133002/diff/40001/appengine/findit/crash/findit_for_chromecrash.py#newcode39 ...
4 years, 2 months ago (2016-09-27 23:14:52 UTC) #7
Sharu Jiang
https://codereview.chromium.org/2373133002/diff/40001/appengine/findit/crash/findit_for_chromecrash.py File appengine/findit/crash/findit_for_chromecrash.py (right): https://codereview.chromium.org/2373133002/diff/40001/appengine/findit/crash/findit_for_chromecrash.py#newcode39 appengine/findit/crash/findit_for_chromecrash.py:39: "found": true, # Indicate whether Findit found any suspects. ...
4 years, 2 months ago (2016-09-27 23:20:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373133002/100001
4 years, 2 months ago (2016-09-29 19:50:28 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 20:04:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/infra/infra/+/9191cc8075241cd6f90bb5382c019...

Powered by Google App Engine
This is Rietveld 408576698