Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: appengine/findit/crash/test/findit_for_chromecrash_test.py

Issue 2373133002: [Findit] Update found_project and found_components. (Closed)
Patch Set: Rebase. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/crash/findit_for_chromecrash.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from common import chromium_deps 5 from common import chromium_deps
6 from common.dependency import DependencyRoll 6 from common.dependency import DependencyRoll
7 from crash import detect_regression_range 7 from crash import detect_regression_range
8 from crash import findit_for_chromecrash 8 from crash import findit_for_chromecrash
9 from crash import fracas_parser 9 from crash import fracas_parser
10 from crash import findit_for_crash 10 from crash import findit_for_crash
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 expected_results = { 95 expected_results = {
96 'found': True, 96 'found': True,
97 'suspected_project': '', 97 'suspected_project': '',
98 'suspected_components': [], 98 'suspected_components': [],
99 'suspected_cls': [dummy_match_result.ToDict()], 99 'suspected_cls': [dummy_match_result.ToDict()],
100 'regression_range': ('50.0.1233.0', '50.0.1234.0'), 100 'regression_range': ('50.0.1233.0', '50.0.1234.0'),
101 } 101 }
102 expected_tag = { 102 expected_tag = {
103 'found_suspects': True, 103 'found_suspects': True,
104 'found_project': False,
105 'found_components': False,
104 'has_regression_range': True, 106 'has_regression_range': True,
105 'solution': 'core_algorithm', 107 'solution': 'core_algorithm',
106 } 108 }
107 109
108 self.assertEqual(expected_results, results) 110 self.assertEqual(expected_results, results)
109 self.assertEqual(expected_tag, tag) 111 self.assertEqual(expected_tag, tag)
110 112
111 results, tag = findit_for_chromecrash.FindCulpritForChromeCrash( 113 results, tag = findit_for_chromecrash.FindCulpritForChromeCrash(
112 'signature', 'win', 'frame1\nframe2', '50.0.1234.0', 114 'signature', 'win', 'frame1\nframe2', '50.0.1234.0',
113 []) 115 [])
114 116
115 expected_results = { 117 expected_results = {
116 'found': False, 118 'found': False,
117 'suspected_project': '', 119 'suspected_project': '',
118 'suspected_components': [], 120 'suspected_components': [],
119 'suspected_cls': [], 121 'suspected_cls': [],
120 'regression_range': None 122 'regression_range': None
121 } 123 }
122 expected_tag = { 124 expected_tag = {
123 'found_suspects': False, 125 'found_suspects': False,
126 'found_project': False,
127 'found_components': False,
124 'has_regression_range': False, 128 'has_regression_range': False,
125 'solution': 'core_algorithm', 129 'solution': 'core_algorithm',
126 } 130 }
127 131
128 self.assertEqual(expected_results, results) 132 self.assertEqual(expected_results, results)
129 self.assertEqual(expected_tag, tag) 133 self.assertEqual(expected_tag, tag)
OLDNEW
« no previous file with comments | « appengine/findit/crash/findit_for_chromecrash.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698