Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: appengine/findit/crash/findit_for_chromecrash.py

Issue 2373133002: [Findit] Update found_project and found_components. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/test/findit_for_chromecrash_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/findit_for_chromecrash.py
diff --git a/appengine/findit/crash/findit_for_chromecrash.py b/appengine/findit/crash/findit_for_chromecrash.py
index c616ec04a9ce04ac10122f9a28ad783aaf9d2dc6..2f83b23a5325e6ba596ba3fd70be1865fcaa738f 100644
--- a/appengine/findit/crash/findit_for_chromecrash.py
+++ b/appengine/findit/crash/findit_for_chromecrash.py
@@ -37,7 +37,9 @@ def FindCulpritForChromeCrash(signature, platform,
(analysis_result_dict, tag_dict)
The analysis result is a dict like below:
{
- "found": true, # Indicate whether Findit found any suspects.
+ # Indicate if Findit found any suspects_cls, suspected_project,
+ # suspected_components or regression_range.
+ "found": true,
"suspected_project": "chromium-v8", # Which project is most suspected.
"feedback_url": "https://.."
"suspected_cls": [
@@ -147,7 +149,7 @@ def FindCulpritForChromeCrash(signature, platform,
return (
{
'found': (bool(suspected_project) or bool(suspected_components) or
- bool(culprit_results_list)),
+ bool(culprit_results_list) or bool(regression_versions)),
'regression_range': regression_versions,
'suspected_project': suspected_project,
'suspected_components': suspected_components,
@@ -155,6 +157,8 @@ def FindCulpritForChromeCrash(signature, platform,
},
{
'found_suspects': bool(culprit_results_list),
+ 'found_project': bool(suspected_project),
+ 'found_components': bool(suspected_components),
'has_regression_range': bool(regression_versions),
'solution': 'core_algorithm',
}
« no previous file with comments | « no previous file | appengine/findit/crash/test/findit_for_chromecrash_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698