[Findit] Update found_project and found_components.

appengine/findit/crash/findit_for_chromecrash.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Process crashes from Chrome crash server and find culprits for them."""
 
 import logging
 
 from common import chromium_deps
 from crash import detect_regression_range
@@ skipping 18 matching lines @@
     signature (str): The signature of a crash on the Chrome crash server.
     stack_trace (str): A string containing the stack trace of a crash.
     crash_version (str): The version of Chrome in which the crash occurred.
     historic_metadata (list): list of dicts mapping from Chrome version to
       historic metadata.
 
   Returns:
     (analysis_result_dict, tag_dict)
     The analysis result is a dict like below:
     {
         "found": true, # Indicate whether Findit found any suspects.

[stgao, 2016/09/27 23:14:52]

As the definition of "found" is changed, we should update this.

More importantly, you should talk to clients like Fracas and Cracas to ensure
this won't cause confusion on their end.

I'm fine with this change if no confusion for clients.

[Sharu Jiang, 2016/09/27 23:20:04]

I will inform clients and update this in related docs.

         "suspected_project": "chromium-v8",  # Which project is most suspected.
         "feedback_url": "https://.."
         "suspected_cls": [
             {
                 "revision": "commit-hash",
                 "url": "https://chromium.googlesource.com/chromium/src/+/ha...",
                 "review_url": "https://codereview.chromium.org/issue-number",
                 "project_path": "third_party/pdfium",
                 "author": "who@chromium.org",
                 "time": "2015-08-17 03:38:16",
@@ skipping 73 matching lines @@
   suspected_components = ComponentClassifier().Classify(
       culprit_results, crash_stack)
 
   # TODO(http://crbug.com/644411): the caller should convert things to
   # JSON, not us.
   culprit_results_list = [result.ToDict() for result in culprit_results]
 
   return (
       {
           'found': (bool(suspected_project) or bool(suspected_components) or
-                    bool(culprit_results_list)),
+                    bool(culprit_results_list) or bool(regression_versions)),
           'regression_range': regression_versions,
           'suspected_project': suspected_project,
           'suspected_components': suspected_components,
           'suspected_cls': culprit_results_list,
       },
       {
           'found_suspects': bool(culprit_results_list),
+          'found_project': bool(suspected_project),
+          'found_components': bool(suspected_components),
           'has_regression_range': bool(regression_versions),
           'solution': 'core_algorithm',
       }
   )