Restrict type attribute on menuitem

Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000
[1] https://html.spec.whatwg.org/#attr-menuitem-type

Committed: https://crrev.com/1c81588c798e7ca59e0e66b5439310c0587a2e6d
Cr-Commit-Position: refs/heads/master@{#432046}

[rwlbuis, 2016-11-11 16:51:11]

Description was changed from

==========
menu item WIP

BUG=
==========

to

==========
menu item WIP

BUG=651762
==========

[rwlbuis, 2016-11-11 18:35:30]

Description was changed from

==========
menu item WIP

BUG=651762
==========

to

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords and states. The
"command" keyword maps to the Command state, the "checkbox" keyword maps to the
Checkbox state, and the "radio" keyword maps to the Radio state. The missing
value default is the Command state."

BUG=651762

[1] https://html.spec.whatwg.org/#attr-menuitem-type
==========

[rwlbuis, 2016-11-11 21:10:26]

Description was changed from

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords and states. The
"command" keyword maps to the Command state, the "checkbox" keyword maps to the
Checkbox state, and the "radio" keyword maps to the Radio state. The missing
value default is the Command state."

BUG=651762

[1] https://html.spec.whatwg.org/#attr-menuitem-type
==========

to

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=651762

[1] https://html.spec.whatwg.org/#attr-menuitem-type
==========

[rwlbuis, 2016-11-14 03:33:06]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2016-11-14 03:33:06]

PTAL.

[tkent, 2016-11-14 03:45:49]

> BUG=651762

It's a meta bug.  Please file a new bug for an actual issue like this.

[tkent, 2016-11-14 03:47:09]

https://codereview.chromium.org/2372593005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp (right):

https://codereview.chromium.org/2372593005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp:53: if
(equalIgnoringCase(menuItemType, "radio")) {
Do you want equalIgnoringCase(), not equalIgnoringASCIICase()?

https://codereview.chromium.org/2372593005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMenuItemElement.idl (right):

https://codereview.chromium.org/2372593005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMenuItemElement.idl:10: [CEReactions]
attribute DOMString type;
Do a combination of ReflectInvalid, ReflectMissing, and ReflectOnly work?

https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...

[rwlbuis, 2016-11-14 15:22:26]

PTAL.

https://codereview.chromium.org/2372593005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp (right):

https://codereview.chromium.org/2372593005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp:53: if
(equalIgnoringCase(menuItemType, "radio")) {
On 2016/11/14 03:47:09, tkent wrote:
> Do you want equalIgnoringCase(), not equalIgnoringASCIICase()?

Yes, very likely. However I will go the autogenerated route and that will end up
using equalIgnoringASCIICase.

https://codereview.chromium.org/2372593005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMenuItemElement.idl (right):

https://codereview.chromium.org/2372593005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMenuItemElement.idl:10: [CEReactions]
attribute DOMString type;
On 2016/11/14 03:47:09, tkent wrote:
> Do a combination of ReflectInvalid, ReflectMissing, and ReflectOnly work?
> 
>
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...
> 

Thanks, I did not know this option existed! I now use this in my latest patch
and it seems to turn up green.

[rwlbuis, 2016-11-14 15:26:27]

Description was changed from

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=651762

[1] https://html.spec.whatwg.org/#attr-menuitem-type
==========

to

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000


[1] https://html.spec.whatwg.org/#attr-menuitem-type
==========

[rwlbuis, 2016-11-14 15:26:58]

On 2016/11/14 03:45:49, tkent wrote:
> > BUG=651762
> 
> It's a meta bug.  Please file a new bug for an actual issue like this.

I filed 665000 and updated the Description.

[tkent, 2016-11-14 22:51:46]

lgtm

[rwlbuis, 2016-11-14 23:19:22]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-11-14 23:21:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 01:44:48]

Description was changed from

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000


[1] https://html.spec.whatwg.org/#attr-menuitem-type
==========

to

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000


[1] https://html.spec.whatwg.org/#attr-menuitem-type
==========

[commit-bot: I haz the power, 2016-11-15 01:44:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-15 01:52:07]

Description was changed from

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000


[1] https://html.spec.whatwg.org/#attr-menuitem-type
==========

to

==========
Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000

[1] https://html.spec.whatwg.org/#attr-menuitem-type

Committed: https://crrev.com/1c81588c798e7ca59e0e66b5439310c0587a2e6d
Cr-Commit-Position: refs/heads/master@{#432046}
==========

[commit-bot: I haz the power, 2016-11-15 01:52:08]

Patchset 3 (id:??) landed as
https://crrev.com/1c81588c798e7ca59e0e66b5439310c0587a2e6d
Cr-Commit-Position: refs/heads/master@{#432046}