Restrict type attribute on menuitem

third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/HTMLMenuItemElement.h"
 
 #include "core/HTMLNames.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/events/Event.h"
 #include "core/frame/UseCounter.h"
@@ skipping 30 matching lines @@
           if (equalIgnoringNullity(groupAttr.impl(), group.impl()))
             menuItem.removeAttribute(checkedAttr);
         }
       }
       setAttribute(checkedAttr, "checked");
     }
     event->setDefaultHandled();
   }
 }
 
+AtomicString HTMLMenuItemElement::type() const {
+  const AtomicString& menuItemType = fastGetAttribute(typeAttr);
+  if (equalIgnoringCase(menuItemType, "radio")) {

[tkent, 2016/11/14 03:47:09]

Do you want equalIgnoringCase(), not equalIgnoringASCIICase()?

[rwlbuis, 2016/11/14 15:22:26]

Yes, very likely. However I will go the autogenerated route and that will end up
using equalIgnoringASCIICase.

+    DEFINE_STATIC_LOCAL(const AtomicString, radio, ("radio"));
+    return radio;
+  }
+  if (equalIgnoringCase(menuItemType, "checkbox")) {
+    DEFINE_STATIC_LOCAL(const AtomicString, checkbox, ("checkbox"));
+    return checkbox;
+  }
+  DEFINE_STATIC_LOCAL(const AtomicString, command, ("command"));
+  return command;
+}
+
+void HTMLMenuItemElement::setType(const AtomicString& menuItemType) {
+  setAttribute(typeAttr, menuItemType);
+}
+
 DEFINE_NODE_FACTORY(HTMLMenuItemElement)
 
 }  // namespace blink