third_party/WebKit/Source/core/html/HTMLMenuItemElement.idl - Issue 2372593005: Restrict type attribute on menuitem

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLMenuItemElement.idl

Issue 2372593005: Restrict type attribute on menuitem (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://html.spec.whatwg.org/#the-menuitem-element	5 // https://html.spec.whatwg.org/#the-menuitem-element

6	6

7 [	7 [

8 RuntimeEnabled=ContextMenu,	8 RuntimeEnabled=ContextMenu,

9 ] interface HTMLMenuItemElement : HTMLElement {	9 ] interface HTMLMenuItemElement : HTMLElement {

10 [CEReactions, Reflect] attribute DOMString type;	10 [CEReactions] attribute DOMString type;
	tkent 2016/11/14 03:47:09 Do a combination of ReflectInvalid, ReflectMissing Do a combination of ReflectInvalid, ReflectMissing, and ReflectOnly work? https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So... rwlbuis 2016/11/14 15:22:26 Thanks, I did not know this option existed! I now Show quoted text On 2016/11/14 03:47:09, tkent wrote: > Do a combination of ReflectInvalid, ReflectMissing, and ReflectOnly work? > > https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So... > Thanks, I did not know this option existed! I now use this in my latest patch and it seems to turn up green.
11 [CEReactions, Reflect] attribute DOMString label;	11 [CEReactions, Reflect] attribute DOMString label;

12 [CEReactions, Reflect, URL] attribute DOMString icon;	12 [CEReactions, Reflect, URL] attribute DOMString icon;

13 [CEReactions, Reflect] attribute boolean disabled;	13 [CEReactions, Reflect] attribute boolean disabled;

14 [CEReactions, Reflect] attribute boolean checked;	14 [CEReactions, Reflect] attribute boolean checked;

15 [CEReactions, Reflect] attribute DOMString radiogroup;	15 [CEReactions, Reflect] attribute DOMString radiogroup;

16 [CEReactions, Reflect] attribute boolean default;	16 [CEReactions, Reflect] attribute boolean default;

17 // FIXME: readonly attribute HTMLElement? command;	17 // FIXME: readonly attribute HTMLElement? command;

18 };	18 };

OLD	NEW