Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2372463002: [Bindings] Pass files to compute_interfaces_info_individual.py in one way (Closed)

Created:
4 years, 2 months ago by peria
Modified:
4 years, 2 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass file names list to compute_interfaces_info_individual.py in one way This is a refactoring change around IDL compiler. BUG=617899 Committed: https://crrev.com/4ca6e02d38f91102e6da13149743b523b4d20a63 Cr-Commit-Position: refs/heads/master@{#420945}

Patch Set 1 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -61 lines) Patch
M third_party/WebKit/Source/bindings/core/BUILD.gn View 1 chunk +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 1 chunk +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py View 3 chunks +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/scripts.gni View 2 chunks +13 lines, -28 lines 3 comments Download

Messages

Total messages: 23 (11 generated)
peria
PTL
4 years, 2 months ago (2016-09-26 06:18:31 UTC) #5
bashi
lgtm with one question https://codereview.chromium.org/2372463002/diff/40001/third_party/WebKit/Source/bindings/scripts/scripts.gni File third_party/WebKit/Source/bindings/scripts/scripts.gni (right): https://codereview.chromium.org/2372463002/diff/40001/third_party/WebKit/Source/bindings/scripts/scripts.gni#newcode77 third_party/WebKit/Source/bindings/scripts/scripts.gni:77: response_file_contents = rebase_path(invoker.sources, root_build_dir) Help ...
4 years, 2 months ago (2016-09-26 06:26:26 UTC) #6
haraken
LGTM
4 years, 2 months ago (2016-09-26 06:30:40 UTC) #7
Yuki
lgtm https://codereview.chromium.org/2372463002/diff/40001/third_party/WebKit/Source/bindings/scripts/scripts.gni File third_party/WebKit/Source/bindings/scripts/scripts.gni (right): https://codereview.chromium.org/2372463002/diff/40001/third_party/WebKit/Source/bindings/scripts/scripts.gni#newcode77 third_party/WebKit/Source/bindings/scripts/scripts.gni:77: response_file_contents = rebase_path(invoker.sources, root_build_dir) On 2016/09/26 06:26:26, bashi1 ...
4 years, 2 months ago (2016-09-26 06:44:33 UTC) #8
peria
https://codereview.chromium.org/2372463002/diff/40001/third_party/WebKit/Source/bindings/scripts/scripts.gni File third_party/WebKit/Source/bindings/scripts/scripts.gni (right): https://codereview.chromium.org/2372463002/diff/40001/third_party/WebKit/Source/bindings/scripts/scripts.gni#newcode77 third_party/WebKit/Source/bindings/scripts/scripts.gni:77: response_file_contents = rebase_path(invoker.sources, root_build_dir) On 2016/09/26 06:26:26, bashi1 wrote: ...
4 years, 2 months ago (2016-09-26 06:47:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372463002/40001
4 years, 2 months ago (2016-09-26 06:51:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147831)
4 years, 2 months ago (2016-09-26 09:31:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372463002/40001
4 years, 2 months ago (2016-09-26 09:34:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147930)
4 years, 2 months ago (2016-09-26 12:05:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372463002/40001
4 years, 2 months ago (2016-09-26 17:07:19 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 2 months ago (2016-09-26 18:42:06 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:44:19 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ca6e02d38f91102e6da13149743b523b4d20a63
Cr-Commit-Position: refs/heads/master@{#420945}

Powered by Google App Engine
This is Rietveld 408576698