Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: third_party/WebKit/Source/bindings/modules/BUILD.gn

Issue 2372463002: [Bindings] Pass files to compute_interfaces_info_individual.py in one way (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/modules/BUILD.gn b/third_party/WebKit/Source/bindings/modules/BUILD.gn
index 559ef048816e748daba52d966b053378684b9769..7a01b57dccf9ea0b41a30e4f03f8a4dafcd23c29 100644
--- a/third_party/WebKit/Source/bindings/modules/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/modules/BUILD.gn
@@ -93,17 +93,9 @@ make_names("event_target_modules_names") {
# ------------------------------------------------------------------------------
-# In GYP, paths needed to be passed separately for static and generated files,
-# as static files are listed in a temporary file (b/c too long for command
-# line), but generated files must be passed at the command line, as their paths
-# are not fixed at GYP time, when the temporary file is generated, because
-# their paths depend on the build directory, which varies.
-#
-# FIXME: GN does not have this limitation and we can combine the lists.
compute_interfaces_info_individual("interfaces_info_individual_modules") {
- sources_static =
- modules_definition_idl_files + modules_static_dependency_idl_files
- sources_generated = modules_generated_dependency_idl_files
+ sources = modules_definition_idl_files + modules_static_dependency_idl_files +
+ modules_generated_dependency_idl_files
interfaces_info_file =
"$bindings_modules_output_dir/InterfacesInfoOverallIndividual.pickle"
component_info_file =

Powered by Google App Engine
This is Rietveld 408576698