Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/bindings/core/BUILD.gn

Issue 2372463002: [Bindings] Pass files to compute_interfaces_info_individual.py in one way (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/core/BUILD.gn b/third_party/WebKit/Source/bindings/core/BUILD.gn
index 132c6491eabbdd86aed23ebb66345e2d96d3d7d7..9ea4f6a4d1802914d46bee7bfab1336ea241a733 100644
--- a/third_party/WebKit/Source/bindings/core/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/core/BUILD.gn
@@ -7,19 +7,8 @@ import("//third_party/WebKit/Source/core/core_idl_files.gni")
visibility = [ "//third_party/WebKit/*" ]
-# Static IDL files / Generated IDL files
-#
-# In GYP, paths needed to be passed separately for static and generated files, as
-# static files are listed in a temporary file (b/c too long for command line),
-# but generated files must be passed at the command line, as their paths are
-# not fixed at GYP time, when the temporary file is generated, because their
-# paths depend on the build directory, which varies.
-#
-# FIXME: GN does not have this restriction and we can combine them.
compute_interfaces_info_individual("interfaces_info_individual_core") {
- sources_static =
- core_static_interface_idl_files + core_static_dependency_idl_files
- sources_generated =
+ sources = core_static_interface_idl_files + core_static_dependency_idl_files +
core_generated_interface_idl_files + core_generated_dependency_idl_files
interfaces_info_file =
"$bindings_core_output_dir/InterfacesInfoCoreIndividual.pickle"

Powered by Google App Engine
This is Rietveld 408576698