Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated

Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated

This patch marks functions {previous,next}PositionOf in VisibleUnits.cpp
deprecated because they take invalid VisiblePositions as input. This patch
also creates the non-deprecated versions of these functions that requires
valid VisiblePositions as input.

Callers passing invalid VisiblePositions have been switched to using the
deprecated functions. Calls in other places have ensured valid VisiblePositions
as input, and hence, are calling the non-deprecated functions after this patch.

BUG=648949
Committed: https://crrev.com/4ebc66c03af35f9294189171d84ebf7c4ba348a3
Cr-Commit-Position: refs/heads/master@{#421414}

[Xiaocheng, 2016-09-27 06:07:38]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 06:08:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-27 06:09:22]

Description was changed from

==========
Mark {previous,next}PositionOf deprecated

BUG=648949
==========

to

==========
Mark {previous,next}PositionOf deprecated

This patch marks functions {previous,next}PositionOf in VisibleUnits.cpp
deprecated because they take invalid VisiblePositions as input. This patch
also creates the non-deprecated versions of these functions that requires
valid VisiblePositions as input.

Callers passing invalid VisiblePositions have been switched to using the
deprecated functions. Calls in other places have ensured valid VisiblePositions
as input, and hence, are calling the non-deprecated functions after this patch.

BUG=648949
==========

[commit-bot: I haz the power, 2016-09-27 07:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 07:43:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2016-09-27 09:02:01]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 09:02:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-27 09:16:48]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-27 09:16:49]

PTAL.

[yosin_UTC9, 2016-09-27 10:05:39]

Let's avoid copy & paste.

https://codereview.chromium.org/2371793003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2371793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:3420: static
VisiblePositionTemplate<Strategy> nextPositionOfAlgorithmDeprecated(const
VisiblePositionTemplate<Strategy>& visiblePosition, EditingBoundaryCrossingRule
rule)
How about making nextPositionOfAlgorithm to take PositionWithAffinity?
We would like to avoid copy & paste since we can't guarantee to change this
function until we get rid of.

https://codereview.chromium.org/2371793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:3513: static
VisiblePositionTemplate<Strategy> previousPositionOfAlgorithmDeprecated(const
VisiblePositionTemplate<Strategy>& visiblePosition, EditingBoundaryCrossingRule
rule)
Ditto as nextPositionOfAlgorithm.

[commit-bot: I haz the power, 2016-09-27 10:29:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 10:29:53]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-27 12:21:30]

Description was changed from

==========
Mark {previous,next}PositionOf deprecated

This patch marks functions {previous,next}PositionOf in VisibleUnits.cpp
deprecated because they take invalid VisiblePositions as input. This patch
also creates the non-deprecated versions of these functions that requires
valid VisiblePositions as input.

Callers passing invalid VisiblePositions have been switched to using the
deprecated functions. Calls in other places have ensured valid VisiblePositions
as input, and hence, are calling the non-deprecated functions after this patch.

BUG=648949
==========

to

==========
Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated

This patch marks functions {previous,next}PositionOf in VisibleUnits.cpp
deprecated because they take invalid VisiblePositions as input. This patch
also creates the non-deprecated versions of these functions that requires
valid VisiblePositions as input.

Callers passing invalid VisiblePositions have been switched to using the
deprecated functions. Calls in other places have ensured valid VisiblePositions
as input, and hence, are calling the non-deprecated functions after this patch.

BUG=648949
==========

[Xiaocheng, 2016-09-27 12:26:23]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 12:26:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-27 12:27:08]

Thanks for the good idea. Updated & PTAL.

https://codereview.chromium.org/2371793003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2371793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:3420: static
VisiblePositionTemplate<Strategy> nextPositionOfAlgorithmDeprecated(const
VisiblePositionTemplate<Strategy>& visiblePosition, EditingBoundaryCrossingRule
rule)
On 2016/09/27 at 10:05:39, Yosi_UTC9 wrote:
> How about making nextPositionOfAlgorithm to take PositionWithAffinity?
> We would like to avoid copy & paste since we can't guarantee to change this
function until we get rid of.

Good idea. Done.

https://codereview.chromium.org/2371793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:3513: static
VisiblePositionTemplate<Strategy> previousPositionOfAlgorithmDeprecated(const
VisiblePositionTemplate<Strategy>& visiblePosition, EditingBoundaryCrossingRule
rule)
On 2016/09/27 at 10:05:39, Yosi_UTC9 wrote:
> Ditto as nextPositionOfAlgorithm.

Done.

[commit-bot: I haz the power, 2016-09-27 13:32:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 13:32:03]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-09-28 01:14:13]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-09-28 01:14:13]

lgtm

[commit-bot: I haz the power, 2016-09-28 01:14:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 01:20:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-28 01:23:26]

Description was changed from

==========
Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated

This patch marks functions {previous,next}PositionOf in VisibleUnits.cpp
deprecated because they take invalid VisiblePositions as input. This patch
also creates the non-deprecated versions of these functions that requires
valid VisiblePositions as input.

Callers passing invalid VisiblePositions have been switched to using the
deprecated functions. Calls in other places have ensured valid VisiblePositions
as input, and hence, are calling the non-deprecated functions after this patch.

BUG=648949
==========

to

==========
Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated

This patch marks functions {previous,next}PositionOf in VisibleUnits.cpp
deprecated because they take invalid VisiblePositions as input. This patch
also creates the non-deprecated versions of these functions that requires
valid VisiblePositions as input.

Callers passing invalid VisiblePositions have been switched to using the
deprecated functions. Calls in other places have ensured valid VisiblePositions
as input, and hence, are calling the non-deprecated functions after this patch.

BUG=648949

Committed: https://crrev.com/4ebc66c03af35f9294189171d84ebf7c4ba348a3
Cr-Commit-Position: refs/heads/master@{#421414}
==========

[commit-bot: I haz the power, 2016-09-28 01:23:27]

Patchset 3 (id:??) landed as
https://crrev.com/4ebc66c03af35f9294189171d84ebf7c4ba348a3
Cr-Commit-Position: refs/heads/master@{#421414}