Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2371793003: Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated (Closed)
Patch Set: Prevent code copying Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 // isn't defined well on flat tree, we should not use it for a position in 131 // isn't defined well on flat tree, we should not use it for a position in
132 // flat tree. 132 // flat tree.
133 CORE_EXPORT VisiblePosition rightPositionOf(const VisiblePosition&); 133 CORE_EXPORT VisiblePosition rightPositionOf(const VisiblePosition&);
134 CORE_EXPORT VisiblePositionInFlatTree rightPositionOf(const VisiblePositionInFla tTree&); 134 CORE_EXPORT VisiblePositionInFlatTree rightPositionOf(const VisiblePositionInFla tTree&);
135 135
136 CORE_EXPORT VisiblePosition nextPositionOf(const VisiblePosition&, EditingBounda ryCrossingRule = CanCrossEditingBoundary); 136 CORE_EXPORT VisiblePosition nextPositionOf(const VisiblePosition&, EditingBounda ryCrossingRule = CanCrossEditingBoundary);
137 CORE_EXPORT VisiblePositionInFlatTree nextPositionOf(const VisiblePositionInFlat Tree&, EditingBoundaryCrossingRule = CanCrossEditingBoundary); 137 CORE_EXPORT VisiblePositionInFlatTree nextPositionOf(const VisiblePositionInFlat Tree&, EditingBoundaryCrossingRule = CanCrossEditingBoundary);
138 CORE_EXPORT VisiblePosition previousPositionOf(const VisiblePosition&, EditingBo undaryCrossingRule = CanCrossEditingBoundary); 138 CORE_EXPORT VisiblePosition previousPositionOf(const VisiblePosition&, EditingBo undaryCrossingRule = CanCrossEditingBoundary);
139 CORE_EXPORT VisiblePositionInFlatTree previousPositionOf(const VisiblePositionIn FlatTree&, EditingBoundaryCrossingRule = CanCrossEditingBoundary); 139 CORE_EXPORT VisiblePositionInFlatTree previousPositionOf(const VisiblePositionIn FlatTree&, EditingBoundaryCrossingRule = CanCrossEditingBoundary);
140 140
141 // These deprecated functions perform synchronous layout, messing up the
142 // rendering pipeline. They may also take invalid VisiblePositions as their
143 // arguments. Callers should ensure clean layout and pass valid VisiblePositions
144 // to the un-deprecated functions listed above.
145 CORE_EXPORT VisiblePosition nextPositionOfDeprecated(const VisiblePosition&, Edi tingBoundaryCrossingRule = CanCrossEditingBoundary);
146 CORE_EXPORT VisiblePositionInFlatTree nextPositionOfDeprecated(const VisiblePosi tionInFlatTree&, EditingBoundaryCrossingRule = CanCrossEditingBoundary);
147 CORE_EXPORT VisiblePosition previousPositionOfDeprecated(const VisiblePosition&, EditingBoundaryCrossingRule = CanCrossEditingBoundary);
148 CORE_EXPORT VisiblePositionInFlatTree previousPositionOfDeprecated(const Visible PositionInFlatTree&, EditingBoundaryCrossingRule = CanCrossEditingBoundary);
149
141 // words 150 // words
142 CORE_EXPORT VisiblePosition startOfWord(const VisiblePosition&, EWordSide = Righ tWordIfOnBoundary); 151 CORE_EXPORT VisiblePosition startOfWord(const VisiblePosition&, EWordSide = Righ tWordIfOnBoundary);
143 CORE_EXPORT VisiblePositionInFlatTree startOfWord(const VisiblePositionInFlatTre e&, EWordSide = RightWordIfOnBoundary); 152 CORE_EXPORT VisiblePositionInFlatTree startOfWord(const VisiblePositionInFlatTre e&, EWordSide = RightWordIfOnBoundary);
144 CORE_EXPORT VisiblePosition endOfWord(const VisiblePosition&, EWordSide = RightW ordIfOnBoundary); 153 CORE_EXPORT VisiblePosition endOfWord(const VisiblePosition&, EWordSide = RightW ordIfOnBoundary);
145 CORE_EXPORT VisiblePositionInFlatTree endOfWord(const VisiblePositionInFlatTree& , EWordSide = RightWordIfOnBoundary); 154 CORE_EXPORT VisiblePositionInFlatTree endOfWord(const VisiblePositionInFlatTree& , EWordSide = RightWordIfOnBoundary);
146 VisiblePosition previousWordPosition(const VisiblePosition&); 155 VisiblePosition previousWordPosition(const VisiblePosition&);
147 VisiblePosition nextWordPosition(const VisiblePosition&); 156 VisiblePosition nextWordPosition(const VisiblePosition&);
148 VisiblePosition rightWordPosition(const VisiblePosition&, bool skipsSpaceWhenMov ingRight); 157 VisiblePosition rightWordPosition(const VisiblePosition&, bool skipsSpaceWhenMov ingRight);
149 VisiblePosition leftWordPosition(const VisiblePosition&, bool skipsSpaceWhenMovi ngRight); 158 VisiblePosition leftWordPosition(const VisiblePosition&, bool skipsSpaceWhenMovi ngRight);
150 159
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 267
259 // Returns a hit-tested VisiblePosition for the given point in contents-space 268 // Returns a hit-tested VisiblePosition for the given point in contents-space
260 // coordinates. 269 // coordinates.
261 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&, Loc alFrame*); 270 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&, Loc alFrame*);
262 271
263 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&); 272 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&);
264 273
265 } // namespace blink 274 } // namespace blink
266 275
267 #endif // VisibleUnits_h 276 #endif // VisibleUnits_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698