third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2371793003: Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2371793003: Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated (Closed)

Patch Set: Prevent code copying Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index dd422c7a00ed50d29be7fdb2ea0d494b67ab01dd..a52f01943dea54a44ce6cfc625b1cdaa6007a4ff 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -1315,8 +1315,8 @@ void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagrap

}

- RelocatablePosition beforeParagraphPosition(previousPositionOf(startOfParagraphToMove, CannotCrossEditingBoundary).deepEquivalent());

- RelocatablePosition afterParagraphPosition(nextPositionOf(endOfParagraphToMove, CannotCrossEditingBoundary).deepEquivalent());

+ RelocatablePosition beforeParagraphPosition(previousPositionOfDeprecated(startOfParagraphToMove, CannotCrossEditingBoundary).deepEquivalent());

+ RelocatablePosition afterParagraphPosition(nextPositionOfDeprecated(endOfParagraphToMove, CannotCrossEditingBoundary).deepEquivalent());

// We upstream() the end and downstream() the start so that we don't include collapsed whitespace in the move.

// When we paste a fragment, spaces after the end and before the start are treated as though they were rendered.