third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp - Issue 2371793003: Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

Issue 2371793003: Mark calls of {previous,next}PositionOf with invalid VisiblePosition deprecated (Closed)

Patch Set: Prevent code copying Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

index 66f6ef94bd8b2d4f2429c3979e0195fc40ec85f2..f1a8000ead0b78edc0c987898019ff9d92dcdc64 100644

--- a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

@@ -248,7 +248,7 @@ void IndentOutdentCommand::outdentRegion(const VisiblePosition& startOfSelection

VisiblePosition endAfterSelection = endOfParagraphDeprecated(nextPositionOf(endOfLastParagraph));

while (endOfCurrentParagraph.deepEquivalent() != endAfterSelection.deepEquivalent()) {

- VisiblePosition endOfNextParagraph = endOfParagraphDeprecated(nextPositionOf(endOfCurrentParagraph));

+ VisiblePosition endOfNextParagraph = endOfParagraphDeprecated(nextPositionOfDeprecated(endOfCurrentParagraph));

if (endOfCurrentParagraph.deepEquivalent() == endOfLastParagraph.deepEquivalent())

setEndingSelection(VisibleSelection(originalSelectionEnd, TextAffinity::Downstream));

else

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | no next file » | no next file with comments »