Switch the DevTools to support a true Dart REPL

Switch the DevTools to support a true Dart REPL

BUG=
R=vsm@google.com

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1379

[Jacob, 2013-09-11 23:45:45]

Ready to review

https://codereview.chromium.org/23710032/diff/10001/Source/bindings/dart/Dart...
File Source/bindings/dart/DartDebugServer.cpp (right):

https://codereview.chromium.org/23710032/diff/10001/Source/bindings/dart/Dart...
Source/bindings/dart/DartDebugServer.cpp:499: {
switching to Dart_EvaluateExpr forced me to add this code back to avoid this
security check issue that V8ScriptRunner worked around.

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
File LayoutTests/dart/inspector/evaluate-in-console.html (right):

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
LayoutTests/dart/inspector/evaluate-in-console.html:81:
'(LinkedList).toString()',
Tweaked the test cases to make more sense given a REPL that actually evaluates
DART code

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
LayoutTests/dart/inspector/evaluate-in-console.html:86: '$var.keys()',
$var is a hack to let you store temp variables in the console. I'm open to other
suggestions.
$var as chosen as it is short, is similar to var, and is unlikely to lead to
name collisions.
Other names considered: $v, $temp, $local

If we wanted to make things a bit more complex, we could rewrite the expressions
sent to the console so that 
var a = 42
was rewritten to
$var.a = 42
but those sorts of rewrites could make the console more fragile and confusing to
use.

[vsm, 2013-09-12 00:17:22]

lgtm with comments

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
File LayoutTests/dart/inspector/evaluate-in-console-expected.txt (right):

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
LayoutTests/dart/inspector/evaluate-in-console-expected.txt:50:
$var.object={"foo": "bar", "baz": 42} = _LinkedHashMap {:foo: "bar", :baz: 42,
_nextEntry@0x23c35ea0: _LinkedHashMapEntry, _previousEntry@0x23c35ea0:
_LinkedHashMapEntry, _elementCount@0x23c35ea0: 2…}
The hex numbers on the previous line might not be consistent across executions /
OSes / ....

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
File LayoutTests/dart/inspector/evaluate-in-console.html (right):

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
LayoutTests/dart/inspector/evaluate-in-console.html:86: '$var.keys()',
On 2013/09/11 23:45:46, Jacob wrote:
> $var is a hack to let you store temp variables in the console. I'm open to
other
> suggestions.
> $var as chosen as it is short, is similar to var, and is unlikely to lead to
> name collisions.
> Other names considered: $v, $temp, $local
> 
> If we wanted to make things a bit more complex, we could rewrite the
expressions
> sent to the console so that 
> var a = 42
> was rewritten to
> $var.a = 42
> but those sorts of rewrites could make the console more fragile and confusing
to
> use.

$var looks pretty magical.

https://codereview.chromium.org/23710032/diff/12001/Source/bindings/dart/Dart...
File Source/bindings/dart/DartDebugServer.cpp (right):

https://codereview.chromium.org/23710032/diff/12001/Source/bindings/dart/Dart...
Source/bindings/dart/DartDebugServer.cpp:447: // Invoke the closure passing in
the
Finish the comment.  :-)

https://codereview.chromium.org/23710032/diff/12001/Source/bindings/dart/Dart...
File Source/bindings/dart/DartHandleProxy.cpp (right):

https://codereview.chromium.org/23710032/diff/12001/Source/bindings/dart/Dart...
Source/bindings/dart/DartHandleProxy.cpp:70: // avoid crashing when handling an
exception triggers an exception.
Should there be a bug opened on this?

[Jacob, 2013-09-17 21:44:42]

Pulled a few more files into this CL and finished the missing wireup of
columnNumber as switching to the non-deprecated Dart VM APIs for looking up
stack traces required changes to related code.

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
File LayoutTests/dart/inspector/evaluate-in-console-expected.txt (right):

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
LayoutTests/dart/inspector/evaluate-in-console-expected.txt:50:
$var.object={"foo": "bar", "baz": 42} = _LinkedHashMap {:foo: "bar", :baz: 42,
_nextEntry@0x23c35ea0: _LinkedHashMapEntry, _previousEntry@0x23c35ea0:
_LinkedHashMapEntry, _elementCount@0x23c35ea0: 2…}
On 2013/09/12 00:17:23, vsm wrote:
> The hex numbers on the previous line might not be consistent across executions
/
> OSes / ....
Agreed. Removed that test case just to be safe.  Longer term I want the debug
view for maps to stop showing privates but still let you get at them. However, I
want to land this CL first.

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
File LayoutTests/dart/inspector/evaluate-in-console.html (right):

https://codereview.chromium.org/23710032/diff/12001/LayoutTests/dart/inspecto...
LayoutTests/dart/inspector/evaluate-in-console.html:86: '$var.keys()',
On 2013/09/12 00:17:23, vsm wrote:
> On 2013/09/11 23:45:46, Jacob wrote:
> > $var is a hack to let you store temp variables in the console. I'm open to
> other
> > suggestions.
> > $var as chosen as it is short, is similar to var, and is unlikely to lead to
> > name collisions.
> > Other names considered: $v, $temp, $local
> > 
> > If we wanted to make things a bit more complex, we could rewrite the
> expressions
> > sent to the console so that 
> > var a = 42
> > was rewritten to
> > $var.a = 42
> > but those sorts of rewrites could make the console more fragile and
confusing
> to
> > use.
> 
> $var looks pretty magical. 
> 
Agreed. After this lands I'm going to send out a follow up CL to eliminate calls
to $var and instead let you just type
var f = (x) => x*42

https://codereview.chromium.org/23710032/diff/12001/Source/bindings/dart/Dart...
File Source/bindings/dart/DartDebugServer.cpp (right):

https://codereview.chromium.org/23710032/diff/12001/Source/bindings/dart/Dart...
Source/bindings/dart/DartDebugServer.cpp:447: // Invoke the closure passing in
the
On 2013/09/12 00:17:23, vsm wrote:
> Finish the comment.  :-)

Done.

https://codereview.chromium.org/23710032/diff/12001/Source/bindings/dart/Dart...
File Source/bindings/dart/DartHandleProxy.cpp (right):

https://codereview.chromium.org/23710032/diff/12001/Source/bindings/dart/Dart...
Source/bindings/dart/DartHandleProxy.cpp:70: // avoid crashing when handling an
exception triggers an exception.
On 2013/09/12 00:17:23, vsm wrote:
> Should there be a bug opened on this?

Yes but that code wasn't changed in this CL. I'll investigate and see if that
FIXME is still needed.

[vsm, 2013-09-17 21:54:25]

lgtm

[Jacob, 2013-09-17 21:55:22]

Committed patchset #3 manually as r1379 (presubmit successful).