Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: Source/bindings/dart/DartDebugHooks.js

Issue 23710032: Switch the DevTools to support a true Dart REPL (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: PTAL Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/inspector/debugger-test.js ('k') | Source/bindings/dart/DartDebugServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartDebugHooks.js
diff --git a/Source/bindings/dart/DartDebugHooks.js b/Source/bindings/dart/DartDebugHooks.js
index c55cfd35bc8ecfb3d70285dcca1e80816fb84cf6..3793cf457749174f4b6c6682bc1f76580866efcd 100644
--- a/Source/bindings/dart/DartDebugHooks.js
+++ b/Source/bindings/dart/DartDebugHooks.js
@@ -105,9 +105,11 @@ DartDebug.Script.prototype = {
DartDebug.FrameMirror = function(callFrame)
{
+ this._callFrame = callFrame;
this._functionName = callFrame.functionName;
this._scriptId = DartDebug.scriptURLToScriptId[callFrame.scriptURL];
this._lineNumber = callFrame.lineNumber;
+ this._columnNumber = callFrame.columnNumber;
this._localScope = new DartDebug.ScopeMirror(callFrame.localScopeProxy, ScopeType.Local);
this._globalScope = new DartDebug.ScopeMirror(callFrame.libraryProxy, ScopeType.Global);
@@ -127,7 +129,7 @@ DartDebug.FrameMirror.prototype = {
sourceLocation: function()
{
- return { line: this._lineNumber, column: 0 };
+ return { line: this._lineNumber, column: this._columnNumber };
},
scopeCount: function()
@@ -155,8 +157,9 @@ DartDebug.FrameMirror.prototype = {
expression = expression.substr(0, expression.lastIndexOf('\n'));
}
- var result = DartDebug.nativeCallbacks.evaluateInScope(expression, this._localScope.receiver(),
- this._globalScope._object, this._localScope._object);
+ var result = DartDebug.nativeCallbacks.invocationTrampoline(
+ DartDebug.nativeCallbacks.evaluateInScope,
+ [expression, this._localScope.receiver(), this._callFrame.functionProxy, this._callFrame.localVariables]);
return { value: function() { return result; } };
},
« no previous file with comments | « LayoutTests/http/tests/inspector/debugger-test.js ('k') | Source/bindings/dart/DartDebugServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698