Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: LayoutTests/http/tests/inspector/debugger-test.js

Issue 23710032: Switch the DevTools to support a true Dart REPL (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: PTAL Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/dart/inspector/evaluate-in-console-expected.txt ('k') | Source/bindings/dart/DartDebugHooks.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/inspector/debugger-test.js
diff --git a/LayoutTests/http/tests/inspector/debugger-test.js b/LayoutTests/http/tests/inspector/debugger-test.js
index f50be12d443acebe220d4598b3e740cc5bab13f2..b5cc3deabf1ecc2f911b9305ce9099a58290a0b7 100644
--- a/LayoutTests/http/tests/inspector/debugger-test.js
+++ b/LayoutTests/http/tests/inspector/debugger-test.js
@@ -110,7 +110,10 @@ InspectorTest.resumeExecution = function(callback)
InspectorTest.waitUntilResumed(callback);
};
-InspectorTest.captureStackTrace = function(callFrames, dropLineNumbers)
+// FIXME: upstream showColumnNumbers field perhaps upstreaming as
+// dropColumnNumbers instead. JavaScript and Dart both support column numbers
+// so upstreaming this change wis very reasonable. dartbug.com/13378
+InspectorTest.captureStackTrace = function(callFrames, dropLineNumbers, showColumnNumbers)
{
InspectorTest.addResult("Call stack:");
for (var i = 0; i < callFrames.length; i++) {
@@ -118,14 +121,17 @@ InspectorTest.captureStackTrace = function(callFrames, dropLineNumbers)
var script = WebInspector.debuggerModel.scriptForId(frame.location.scriptId);
var url;
var lineNumber;
+ var columnNumber;
if (script) {
url = WebInspector.displayNameForURL(script.sourceURL);
lineNumber = frame.location.lineNumber + 1;
+ columnNumber = frame.location.columnNumber + 1;
} else {
url = "(internal script)";
lineNumber = "(line number)";
+ columnNumber = "(column number)";
}
- var s = " " + i + ") " + frame.functionName + " (" + url + (dropLineNumbers ? "" : ":" + lineNumber) + ")";
+ var s = " " + i + ") " + frame.functionName + " (" + url + (dropLineNumbers ? "" : ":" + lineNumber + (showColumnNumbers ? ":" + columnNumber : "")) + ")";
InspectorTest.addResult(s);
}
};
« no previous file with comments | « LayoutTests/dart/inspector/evaluate-in-console-expected.txt ('k') | Source/bindings/dart/DartDebugHooks.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698