Refactor LocalBorderBoxProperties to use PropertyTreeState

Refactor LocalBorderBoxProperties to use PropertyTreeState

LocalBorderBoxProperties does not need to store refptrs as it only
references existing properties (inherited or owned). This patch makes
that explicit which also aligns the implementation with how FrameView's
totalPropertyTreeStateForContents works.

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[pdr., 2016-09-23 21:53:24]

Description was changed from

==========
Refactor LocalBorderBoxProperties to use PropertyTreeState

Not yet for review, crashes until we can get RLS to use the root clip node.

BUG=645615
==========

to

==========
Refactor LocalBorderBoxProperties to use PropertyTreeState

Not yet for review, crashes until we can get RLS to use the root clip node.

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-09-23 22:41:32]

Description was changed from

==========
Refactor LocalBorderBoxProperties to use PropertyTreeState

Not yet for review, crashes until we can get RLS to use the root clip node.

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Refactor LocalBorderBoxProperties to use PropertyTreeState

LocalBorderBoxProperties does not need to store refptrs as it only
references existing properties (inherited or owned). This patch makes
that explicit which also aligns the implementation with how FrameView's
totalPropertyTreeStateForContents works.

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-09-23 22:41:32]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, szager@chromium.org, trchen@chromium.org

[szager1, 2016-09-24 01:30:18]

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp (right):

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp:23: else if
(cssClip())
Is it possible to have both overflow and css clip?

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:107:
GeometryPropertyTreeState getContentsProperties() const;
Why do we need both PropertyTreeState and GeometryPropertyTreeState?

[chrishtr, 2016-09-26 17:09:51]

I don't see the part of this patch that changes something to do with RefPtrs, as
mentioned
in the description. ?

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp (left):

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp:9: void
ObjectPaintProperties::getContentsProperties(GeometryPropertyTreeState&
properties) const
The old code was optimized to remove an extra copy constructor of
GeometryPropertyTreeState.

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp (right):

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp:23: else if
(cssClip())
On 2016/09/24 at 01:30:17, szager1 wrote:
> Is it possible to have both overflow and css clip?

yes

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):

https://codereview.chromium.org/2370553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:41: // 2.
[Optional] A suite of property nodes (PropertyTreeState) and paint offset
Remove the parenthetical, not accurate at this point.

[pdr., 2016-09-29 18:11:17]

Thanks for the reviews. I think a slightly different approach will be better
here. I talked with Chris about it on Monday and finally created a new patch:
https://codereview.chromium.org/2378883003