Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2364233002: Switch the Root Layer Scrolls codepath to use root clip paint properties (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
chrishtr, szager1, trchen
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch the Root Layer Scrolls codepath to use root clip paint properties This is a followup to [1] to start moving the root layer scrolls codepath to use the new root property tree nodes. Only the clip node has been done in this patch which unblocks [2] which will unblock switching the rest of the root layer scrolls root nodes over. [1] https://crrev.com/a518f5340802393f8bdaa6b3d376dc5482049351 [2] https://codereview.chromium.org/2370553002 BUG=645615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/6dbe31ae92f52661dfa4d2af4fdf768707b5cf31 Cr-Commit-Position: refs/heads/master@{#420816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h View 2 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
pdr.
4 years, 3 months ago (2016-09-23 22:05:05 UTC) #3
szager1
lgtm
4 years, 3 months ago (2016-09-24 01:31:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364233002/1
4 years, 3 months ago (2016-09-24 02:18:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-24 02:24:07 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-24 02:26:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dbe31ae92f52661dfa4d2af4fdf768707b5cf31
Cr-Commit-Position: refs/heads/master@{#420816}

Powered by Google App Engine
This is Rietveld 408576698