third_party/WebKit/Source/core/paint/PaintInvalidator.cpp - Issue 2370553002: Refactor LocalBorderBoxProperties to use PropertyTreeState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Issue 2370553002: Refactor LocalBorderBoxProperties to use PropertyTreeState (Closed)

Patch Set: Rebase from space Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp ('K') | « third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

index be05bd7667b0e4bc938904da9595020d0faa96d1..c1b0b10d9dbe2c8746860def5b70130b2762c6bb 100644

--- a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

@@ -62,9 +62,8 @@ static LayoutRect mapLocalRectToPaintInvalidationBacking(GeometryMapper& geometr

rect.moveBy(FloatPoint(context.treeBuilderContext.current.paintOffset));

GeometryPropertyTreeState currentTreeState(context.treeBuilderContext.current.transform, context.treeBuilderContext.current.clip, context.treeBuilderContext.currentEffect);

- GeometryPropertyTreeState containerTreeState;

const ObjectPaintProperties* containerPaintProperties = context.paintInvalidationContainer->objectPaintProperties();

- containerPaintProperties->getContentsProperties(containerTreeState);

+ GeometryPropertyTreeState containerTreeState = containerPaintProperties->getContentsProperties();

bool success = false;

result = LayoutRect(geometryMapper.mapToVisualRectInDestinationSpace(rect, currentTreeState, containerTreeState, success));

@@ -107,8 +106,7 @@ LayoutPoint PaintInvalidator::computeLocationFromPaintInvalidationBacking(const

bool success = false;

GeometryPropertyTreeState currentTreeState(context.treeBuilderContext.current.transform, context.treeBuilderContext.current.clip, context.treeBuilderContext.currentEffect);

- GeometryPropertyTreeState containerTreeState;

- context.paintInvalidationContainer->objectPaintProperties()->getContentsProperties(containerTreeState);

+ GeometryPropertyTreeState containerTreeState = context.paintInvalidationContainer->objectPaintProperties()->getContentsProperties();

point = m_geometryMapper.mapRectToDestinationSpace(FloatRect(point, FloatSize()), currentTreeState, containerTreeState, success).location();

DCHECK(success);

}