Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Issue 2378883003: Refactor PropertyTreeState to use RefPtrs (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor PropertyTreeState to use RefPtrs PropertyTreeState stores the total state of the property trees at some given time. At the moment this is only used for FrameView, but I'd like to use PropertyTreeState in LocalBorderBoxProperties in the future. The purpose of this patch is twofold: 1) Guard against use-after-free bugs as we add support for incremental updates to the property trees. 2) Prepare to refactor LocalBorderBoxProperties (which uses RefPtrs) to use PropertyTreeState. BUG=645615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/f0ebdb54d79437c44dc8664f011aaa6a7bb49f5f Cr-Commit-Position: refs/heads/master@{#421943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 1 chunk +21 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pdr.
4 years, 2 months ago (2016-09-29 18:11:39 UTC) #6
chrishtr
lgtm
4 years, 2 months ago (2016-09-29 20:40:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378883003/1
4 years, 2 months ago (2016-09-29 20:41:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 21:49:00 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 21:52:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0ebdb54d79437c44dc8664f011aaa6a7bb49f5f
Cr-Commit-Position: refs/heads/master@{#421943}

Powered by Google App Engine
This is Rietveld 408576698