Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2369863004: Move more members from QuicClient to QuicClientBase and change (Closed)

Created:
4 years, 2 months ago by Ryan Hamilton
Modified:
4 years, 2 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more members from QuicClient to QuicClientBase and change set_response_listener from taking a pointer to a unique_ptr. Merge internal change: 134417781 Committed: https://crrev.com/71c83b0c7fa0d77337d3fe61be72f9785765c579 Cr-Commit-Position: refs/heads/master@{#421310}

Patch Set 1 #

Patch Set 2 : simple client #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -249 lines) Patch
M net/tools/quic/end_to_end_test.cc View 5 chunks +15 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client.h View 7 chunks +0 lines, -65 lines 0 comments Download
M net/tools/quic/quic_client.cc View 6 chunks +12 lines, -72 lines 0 comments Download
M net/tools/quic/quic_client_base.h View 5 chunks +64 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_base.cc View 6 chunks +68 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_client.h View 1 4 chunks +0 lines, -56 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 6 chunks +14 lines, -48 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
Ryan Hamilton
4 years, 2 months ago (2016-09-27 17:00:25 UTC) #4
Zhongyi Shi
lgtm You might want to include the internal cl number for future ref =)
4 years, 2 months ago (2016-09-27 17:14:17 UTC) #5
Ryan Hamilton
On 2016/09/27 17:14:17, Zhongyi Shi wrote: > lgtm > > You might want to include ...
4 years, 2 months ago (2016-09-27 19:51:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369863004/40001
4 years, 2 months ago (2016-09-27 19:52:05 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-27 19:58:56 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 20:02:58 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/71c83b0c7fa0d77337d3fe61be72f9785765c579
Cr-Commit-Position: refs/heads/master@{#421310}

Powered by Google App Engine
This is Rietveld 408576698