Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: net/tools/quic/quic_simple_client.cc

Issue 2369863004: Move more members from QuicClient to QuicClientBase and change (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_simple_client.cc
diff --git a/net/tools/quic/quic_simple_client.cc b/net/tools/quic/quic_simple_client.cc
index 141ba60d8bb59bf9069a14127d9f8e51b7789379..d7bb26faed23135c83f5cd5d151bb9746f0365f1 100644
--- a/net/tools/quic/quic_simple_client.cc
+++ b/net/tools/quic/quic_simple_client.cc
@@ -43,11 +43,11 @@ QuicSimpleClient::QuicSimpleClient(
CreateQuicConnectionHelper(),
CreateQuicAlarmFactory(),
std::move(proof_verifier)),
- server_address_(server_address),
- local_port_(0),
initialized_(false),
packet_reader_started_(false),
- weak_factory_(this) {}
+ weak_factory_(this) {
+ set_server_address(server_address);
+}
QuicSimpleClient::QuicSimpleClient(
IPEndPoint server_address,
@@ -61,11 +61,11 @@ QuicSimpleClient::QuicSimpleClient(
CreateQuicConnectionHelper(),
CreateQuicAlarmFactory(),
std::move(proof_verifier)),
- server_address_(server_address),
- local_port_(0),
initialized_(false),
packet_reader_started_(false),
- weak_factory_(this) {}
+ weak_factory_(this) {
+ set_server_address(server_address);
+}
QuicSimpleClient::~QuicSimpleClient() {
if (connected()) {
@@ -93,16 +93,16 @@ bool QuicSimpleClient::CreateUDPSocket() {
new UDPClientSocket(DatagramSocket::DEFAULT_BIND, RandIntCallback(),
&net_log_, NetLog::Source()));
- int address_family = server_address_.GetSockAddrFamily();
- if (bind_to_address_.size() != 0) {
- client_address_ = IPEndPoint(bind_to_address_, local_port_);
+ int address_family = server_address().GetSockAddrFamily();
+ if (bind_to_address().size() != 0) {
+ client_address_ = IPEndPoint(bind_to_address(), local_port());
} else if (address_family == AF_INET) {
- client_address_ = IPEndPoint(IPAddress::IPv4AllZeros(), local_port_);
+ client_address_ = IPEndPoint(IPAddress::IPv4AllZeros(), local_port());
} else {
- client_address_ = IPEndPoint(IPAddress::IPv6AllZeros(), local_port_);
+ client_address_ = IPEndPoint(IPAddress::IPv6AllZeros(), local_port());
}
- int rc = socket->Connect(server_address_);
+ int rc = socket->Connect(server_address());
if (rc != OK) {
LOG(ERROR) << "Connect failed: " << ErrorToShortString(rc);
return false;
@@ -195,7 +195,7 @@ void QuicSimpleClient::StartConnect() {
}
CreateQuicClientSession(new QuicConnection(
- GetNextConnectionId(), server_address_, helper(), alarm_factory(),
+ GetNextConnectionId(), server_address(), helper(), alarm_factory(),
writer(),
/* owns_writer= */ false, Perspective::IS_CLIENT, supported_versions()));
@@ -293,7 +293,7 @@ bool QuicSimpleClient::MigrateSocket(const IPAddress& new_host) {
return false;
}
- bind_to_address_ = new_host;
+ set_bind_to_address(new_host);
if (!CreateUDPSocket()) {
return false;
}
@@ -307,40 +307,6 @@ bool QuicSimpleClient::MigrateSocket(const IPAddress& new_host) {
return true;
}
-void QuicSimpleClient::OnClose(QuicSpdyStream* stream) {
- DCHECK(stream != nullptr);
- QuicSpdyClientStream* client_stream =
- static_cast<QuicSpdyClientStream*>(stream);
- HttpResponseInfo response;
- SpdyHeadersToHttpResponse(client_stream->response_headers(), &response);
- if (response_listener_.get() != nullptr) {
- response_listener_->OnCompleteResponse(stream->id(), *response.headers,
- client_stream->data());
- }
-
- // Store response headers and body.
- if (store_response_) {
- latest_response_code_ = client_stream->response_code();
- response.headers->GetNormalizedHeaders(&latest_response_headers_);
- latest_response_body_ = client_stream->data();
- }
-}
-
-size_t QuicSimpleClient::latest_response_code() const {
- LOG_IF(DFATAL, !store_response_) << "Response not stored!";
- return latest_response_code_;
-}
-
-const string& QuicSimpleClient::latest_response_headers() const {
- LOG_IF(DFATAL, !store_response_) << "Response not stored!";
- return latest_response_headers_;
-}
-
-const string& QuicSimpleClient::latest_response_body() const {
- LOG_IF(DFATAL, !store_response_) << "Response not stored!";
- return latest_response_body_;
-}
-
QuicConnectionId QuicSimpleClient::GenerateNewConnectionId() {
return helper()->GetRandomGenerator()->RandUint64();
}
« no previous file with comments | « net/tools/quic/quic_simple_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698