Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 2369863004: Move more members from QuicClient to QuicClientBase and change (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/tools/quic/quic_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index f7efc2e1d8ea0e02520112b54d00a8b90a5df079..0f4c1534c2cff3a1c14a3fc4e5515bcf53d87811 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -2583,7 +2583,9 @@ TEST_P(EndToEndTestServerPush, ServerPush) {
AddRequestAndResponseWithServerPush("example.com", "/push_example", kBody,
push_urls, kNumResources, 0);
- client_->client()->set_response_listener(new TestResponseListener);
+ client_->client()->set_response_listener(
+ std::unique_ptr<QuicClientBase::ResponseListener>(
+ new TestResponseListener));
DVLOG(1) << "send request for /push_example";
EXPECT_EQ(kBody, client_->SendSynchronousRequest(
@@ -2619,7 +2621,9 @@ TEST_P(EndToEndTestServerPush, ServerPushUnderLimit) {
};
AddRequestAndResponseWithServerPush("example.com", "/push_example", kBody,
push_urls, kNumResources, 0);
- client_->client()->set_response_listener(new TestResponseListener);
+ client_->client()->set_response_listener(
+ std::unique_ptr<QuicClientBase::ResponseListener>(
+ new TestResponseListener));
// Send the first request: this will trigger the server to send all the push
// resources associated with this request, and these will be cached by the
@@ -2665,7 +2669,9 @@ TEST_P(EndToEndTestServerPush, ServerPushOverLimitNonBlocking) {
}
AddRequestAndResponseWithServerPush("example.com", "/push_example", kBody,
push_urls, kNumResources, 0);
- client_->client()->set_response_listener(new TestResponseListener);
+ client_->client()->set_response_listener(
+ std::unique_ptr<QuicClientBase::ResponseListener>(
+ new TestResponseListener));
// Send the first request: this will trigger the server to send all the push
// resources associated with this request, and these will be cached by the
@@ -2721,7 +2727,9 @@ TEST_P(EndToEndTestServerPush, ServerPushOverLimitWithBlocking) {
AddRequestAndResponseWithServerPush("example.com", "/push_example", kBody,
push_urls, kNumResources, kBodySize);
- client_->client()->set_response_listener(new TestResponseListener);
+ client_->client()->set_response_listener(
+ std::unique_ptr<QuicClientBase::ResponseListener>(
+ new TestResponseListener));
client_->SendRequest("https://example.com/push_example");
@@ -2785,7 +2793,9 @@ TEST_P(EndToEndTestServerPush, DisabledWithoutConnectionOption) {
};
AddRequestAndResponseWithServerPush("example.com", "/push_example", kBody,
push_urls, kNumResources, 0);
- client_->client()->set_response_listener(new TestResponseListener);
+ client_->client()->set_response_listener(
+ std::unique_ptr<QuicClientBase::ResponseListener>(
+ new TestResponseListener));
EXPECT_EQ(kBody, client_->SendSynchronousRequest(
"https://example.com/push_example"));
« no previous file with comments | « no previous file | net/tools/quic/quic_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698