Move QuicClient::ClientQuicDataToResend from QuicClient to QuicClientBase.

Move QuicClient::ClientQuicDataToResend from QuicClient to QuicClientBase.

Merge internal change: 134339524

Committed: https://crrev.com/dfcc7d6be03265685818afba45521e3092516496
Cr-Commit-Position: refs/heads/master@{#421289}

[Ryan Hamilton, 2016-09-27 04:21:44]

rch@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Zhongyi Shi, 2016-09-27 04:40:25]

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client.cc
File net/tools/quic/quic_client.cc (right):

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client....
net/tools/quic/quic_client.cc:173: // Resend any previously queued data.
nit: comments here seem to be out of sync with internal code?

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client_...
File net/tools/quic/quic_client_base.h (right):

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client_...
net/tools/quic/quic_client_base.h:73: ~QuicClientBase() override;
Why this need to be overridden? I thought it should be a virtual destructor for
the base class.

[Ryan Hamilton, 2016-09-27 14:27:55]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[Ryan Hamilton, 2016-09-27 14:28:00]

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client.cc
File net/tools/quic/quic_client.cc (right):

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client....
net/tools/quic/quic_client.cc:173: // Resend any previously queued data.
On 2016/09/27 04:40:25, Zhongyi Shi wrote:
> nit: comments here seem to be out of sync with internal code?

Silly long story, but will be fixed in the next cl.

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client_...
File net/tools/quic/quic_client_base.h (right):

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client_...
net/tools/quic/quic_client_base.h:73: ~QuicClientBase() override;
On 2016/09/27 04:40:25, Zhongyi Shi wrote:
> Why this need to be overridden? I thought it should be a virtual destructor
for
> the base class. 

Because QuicClientBase is no longer just a base class. It now extends two
others, and chromium compilers complain otherwise.

[commit-bot: I haz the power, 2016-09-27 14:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:15:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ryan Hamilton, 2016-09-27 16:43:03]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 16:43:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2016-09-27 17:06:57]

lgtm

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client_...
File net/tools/quic/quic_client_base.h (right):

https://codereview.chromium.org/2368183003/diff/1/net/tools/quic/quic_client_...
net/tools/quic/quic_client_base.h:73: ~QuicClientBase() override;
On 2016/09/27 14:28:00, Ryan Hamilton wrote:
> On 2016/09/27 04:40:25, Zhongyi Shi wrote:
> > Why this need to be overridden? I thought it should be a virtual destructor
> for
> > the base class. 
> 
> Because QuicClientBase is no longer just a base class. It now extends two
> others, and chromium compilers complain otherwise.

Acknowledged.

[commit-bot: I haz the power, 2016-09-27 17:46:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 17:46:47]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-09-27 19:01:16]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:01:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:09:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 19:12:11]

Description was changed from

==========
Move QuicClient::ClientQuicDataToResend from QuicClient to QuicClientBase.

Merge internal change: 134339524
==========

to

==========
Move QuicClient::ClientQuicDataToResend from QuicClient to QuicClientBase.

Merge internal change: 134339524

Committed: https://crrev.com/dfcc7d6be03265685818afba45521e3092516496
Cr-Commit-Position: refs/heads/master@{#421289}
==========

[commit-bot: I haz the power, 2016-09-27 19:12:12]

Patchset 2 (id:??) landed as
https://crrev.com/dfcc7d6be03265685818afba45521e3092516496
Cr-Commit-Position: refs/heads/master@{#421289}