change return type of StartNetLogToFile

change return type of StartNetLogToFile

it now returns false if it fails to open the log file

BUG=497860
Committed: https://crrev.com/9bd4961e751b6425484b1f212d2da578f918ba1a
Cr-Commit-Position: refs/heads/master@{#421529}

[lilyhoughton, 2016-09-26 16:29:58]

lilyhoughton@chromium.org changed reviewers:
+ xunjieli@chromium.org

[lilyhoughton, 2016-09-26 16:29:58]

I changed the return type of the startNetLogToFile function so that it returns
false when fails to open log file.

[xunjieli, 2016-09-26 16:35:39]

Looks great. Two comments below.

https://codereview.chromium.org/2368663002/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_url_request_context_adapter.h (right):

https://codereview.chromium.org/2368663002/diff/1/components/cronet/android/c...
components/cronet/android/cronet_url_request_context_adapter.h:82: // Starts
NetLog logging to file. This can be called on any thread.
Could you document the return value in the comment as well?
Something like:

// Starts NetLog logging to file. Returns false upon failure.
// This can be called on any thread.

https://codereview.chromium.org/2368663002/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
(right):

https://codereview.chromium.org/2368663002/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java:263:
nativeStartNetLogToFile(mUrlRequestContextAdapter, fileName, logAll);
Could you check the return value of this function. If false, could you throw a
runtime exception to let the caller know?

something like:

if (!nativeStartNetLogToFile()) {
   throw new RuntimeException("Unable to start NetLog");
}

[xunjieli, 2016-09-27 20:23:23]

Normally what we do is to "Publish+Mail Comments" so the reviewer can get an
email about the Cl and know it's time to do another round of review.

This LGTM. I've kicked off a run on "android_cronet_tester" which runs Cronet
tests. Once it turns green, you can check the "Commit" checkbox and your Cl will
go into the Commit Queue. Once everything goes well, your CL will land in the
Chromium repo.

Let me know if you have any question.

[lilyhoughton, 2016-09-28 15:44:48]

The CQ bit was checked by lilyhoughton@chromium.org

[commit-bot: I haz the power, 2016-09-28 15:45:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 15:54:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 15:58:24]

Description was changed from

==========
change return type of StartNetLogToFile

it now returns false if it fails to open the log file

BUG=497860
==========

to

==========
change return type of StartNetLogToFile

it now returns false if it fails to open the log file

BUG=497860

Committed: https://crrev.com/9bd4961e751b6425484b1f212d2da578f918ba1a
Cr-Commit-Position: refs/heads/master@{#421529}
==========

[commit-bot: I haz the power, 2016-09-28 15:58:25]

Patchset 2 (id:??) landed as
https://crrev.com/9bd4961e751b6425484b1f212d2da578f918ba1a
Cr-Commit-Position: refs/heads/master@{#421529}