Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: components/cronet/android/cronet_url_request_context_adapter.h

Issue 2368663002: change return type of StartNetLogToFile (Closed)
Patch Set: add documentation comment and improve test for startNetLogToFile Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/cronet_url_request_context_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/cronet_url_request_context_adapter.h
diff --git a/components/cronet/android/cronet_url_request_context_adapter.h b/components/cronet/android/cronet_url_request_context_adapter.h
index 901f26c67c208c70861fb09b9ed5af8716c7c49f..647cc0630742fe8db1f70a26a5e4355b8b664c15 100644
--- a/components/cronet/android/cronet_url_request_context_adapter.h
+++ b/components/cronet/android/cronet_url_request_context_adapter.h
@@ -79,8 +79,9 @@ class CronetURLRequestContextAdapter
net::URLRequestContext* GetURLRequestContext();
- // Starts NetLog logging to file. This can be called on any thread.
- void StartNetLogToFile(JNIEnv* env,
+ // Starts NetLog logging to file. This can be called on any thread. Returns
+ // false if it fails to open log file.
+ bool StartNetLogToFile(JNIEnv* env,
const base::android::JavaParamRef<jobject>& jcaller,
const base::android::JavaParamRef<jstring>& jfile_name,
jboolean jlog_all);
« no previous file with comments | « no previous file | components/cronet/android/cronet_url_request_context_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698