Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: components/cronet/android/cronet_url_request_context_adapter.h

Issue 2368663002: change return type of StartNetLogToFile (Closed)
Patch Set: add documentation comment and improve test for startNetLogToFile Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/cronet/android/cronet_url_request_context_adapter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_ 5 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
6 #define COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_ 6 #define COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 // Posts a task that might depend on the context being initialized 73 // Posts a task that might depend on the context being initialized
74 // to the network thread. 74 // to the network thread.
75 void PostTaskToNetworkThread(const tracked_objects::Location& posted_from, 75 void PostTaskToNetworkThread(const tracked_objects::Location& posted_from,
76 const base::Closure& callback); 76 const base::Closure& callback);
77 77
78 bool IsOnNetworkThread() const; 78 bool IsOnNetworkThread() const;
79 79
80 net::URLRequestContext* GetURLRequestContext(); 80 net::URLRequestContext* GetURLRequestContext();
81 81
82 // Starts NetLog logging to file. This can be called on any thread. 82 // Starts NetLog logging to file. This can be called on any thread. Returns
83 void StartNetLogToFile(JNIEnv* env, 83 // false if it fails to open log file.
84 bool StartNetLogToFile(JNIEnv* env,
84 const base::android::JavaParamRef<jobject>& jcaller, 85 const base::android::JavaParamRef<jobject>& jcaller,
85 const base::android::JavaParamRef<jstring>& jfile_name, 86 const base::android::JavaParamRef<jstring>& jfile_name,
86 jboolean jlog_all); 87 jboolean jlog_all);
87 88
88 // Starts NetLog logging to disk with a bounded amount of disk space. This 89 // Starts NetLog logging to disk with a bounded amount of disk space. This
89 // can be called on any thread. 90 // can be called on any thread.
90 void StartNetLogToDisk(JNIEnv* env, 91 void StartNetLogToDisk(JNIEnv* env,
91 const base::android::JavaParamRef<jobject>& jcaller, 92 const base::android::JavaParamRef<jobject>& jcaller,
92 const base::android::JavaParamRef<jstring>& jdir_name, 93 const base::android::JavaParamRef<jstring>& jdir_name,
93 jboolean jlog_all, 94 jboolean jlog_all,
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 #if defined(DATA_REDUCTION_PROXY_SUPPORT) 237 #if defined(DATA_REDUCTION_PROXY_SUPPORT)
237 std::unique_ptr<CronetDataReductionProxy> data_reduction_proxy_; 238 std::unique_ptr<CronetDataReductionProxy> data_reduction_proxy_;
238 #endif 239 #endif
239 240
240 DISALLOW_COPY_AND_ASSIGN(CronetURLRequestContextAdapter); 241 DISALLOW_COPY_AND_ASSIGN(CronetURLRequestContextAdapter);
241 }; 242 };
242 243
243 } // namespace cronet 244 } // namespace cronet
244 245
245 #endif // COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_ 246 #endif // COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
OLDNEW
« no previous file with comments | « no previous file | components/cronet/android/cronet_url_request_context_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698