change return type of StartNetLogToFile

components/cronet/android/cronet_url_request_context_adapter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
 #define COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
 
 #include <jni.h>
 #include <stdint.h>
 
@@ skipping 61 matching lines @@
 
   // Posts a task that might depend on the context being initialized
   // to the network thread.
   void PostTaskToNetworkThread(const tracked_objects::Location& posted_from,
                                const base::Closure& callback);
 
   bool IsOnNetworkThread() const;
 
   net::URLRequestContext* GetURLRequestContext();
 
   // Starts NetLog logging to file. This can be called on any thread.

[xunjieli, 2016/09/26 16:35:39]

Could you document the return value in the comment as well?
Something like:

// Starts NetLog logging to file. Returns false upon failure.
// This can be called on any thread.

-  void StartNetLogToFile(JNIEnv* env,
+  bool StartNetLogToFile(JNIEnv* env,
                          const base::android::JavaParamRef<jobject>& jcaller,
                          const base::android::JavaParamRef<jstring>& jfile_name,
                          jboolean jlog_all);
 
   // Starts NetLog logging to disk with a bounded amount of disk space. This
   // can be called on any thread.
   void StartNetLogToDisk(JNIEnv* env,
                          const base::android::JavaParamRef<jobject>& jcaller,
                          const base::android::JavaParamRef<jstring>& jdir_name,
                          jboolean jlog_all,
@@ skipping 142 matching lines @@
 #if defined(DATA_REDUCTION_PROXY_SUPPORT)
   std::unique_ptr<CronetDataReductionProxy> data_reduction_proxy_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(CronetURLRequestContextAdapter);
 };
 
 }  // namespace cronet
 
 #endif  // COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_