[NTP Snippets] Cleanups from clang-tidy

[NTP Snippets] Cleanups from clang-tidy

I ran clang-tidy (https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md) on components/ntp_snippets/ and fixed a bunch of the non-false-positives :)

BUG=none

Committed: https://crrev.com/62e819e9d577e6a24d4199343fe244dee2bca4a1
Cr-Commit-Position: refs/heads/master@{#421173}

[Marc Treib, 2016-09-23 16:40:36]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 16:40:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-09-23 16:42:43]

treib@chromium.org changed reviewers:
+ jkrcal@chromium.org

[Marc Treib, 2016-09-23 16:42:44]

Here's the result so far from running clang-tidy over our code after some
fiddling with params, to disable checks that are not useful, don't apply, or
just produce too many false positives. I'll write up a how-to one of these days
:)

All of the changes here are quite minor, which I take as a good sign!

https://codereview.chromium.org/2368583002/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.cc (left):

https://codereview.chromium.org/2368583002/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:196:
std::vector<ContentSuggestion> new_suggestions) {
To match the declaration in the header

[sfiera, 2016-09-23 16:51:04]

Read through and saw one other that wasn't obvious (to me):

https://codereview.chromium.org/2368583002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service.cc (right):

https://codereview.chromium.org/2368583002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service.cc:753: data,
base::Bind(&NTPSnippetsService::OnSnippetImageDecodedFromDatabase,
Because DecodeImage takes a const std::string&, so moving it isn't going to
prevent any copies.

[Marc Treib, 2016-09-23 16:53:07]

https://codereview.chromium.org/2368583002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service.cc (right):

https://codereview.chromium.org/2368583002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service.cc:753: data,
base::Bind(&NTPSnippetsService::OnSnippetImageDecodedFromDatabase,
On 2016/09/23 16:51:04, sfiera wrote:
> Because DecodeImage takes a const std::string&, so moving it isn't going to
> prevent any copies.

Good point, I could have mentioned that one :)

[commit-bot: I haz the power, 2016-09-23 17:42:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 17:42:24]

Dry run: This issue passed the CQ dry run.

[tschumann, 2016-09-26 09:02:43]

tschumann@chromium.org changed reviewers:
+ tschumann@chromium.org

[tschumann, 2016-09-26 09:02:44]

lgtm

Nice!

[Marc Treib, 2016-09-27 10:24:35]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2016-09-27 10:24:35]

+sfiera: Since jkrcal is out today, care to use your awesome committer powers to
approve this? Thanks!

[sfiera, 2016-09-27 10:30:40]

LGTM

[Marc Treib, 2016-09-27 10:32:50]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 10:33:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-09-27 11:20:59]

The CQ bit was unchecked by treib@chromium.org

[Marc Treib, 2016-09-27 11:21:04]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-09-27 11:21:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
tschumann@chromium.org
Link to the patchset: https://codereview.chromium.org/2368583002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-27 11:21:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 11:47:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 11:50:06]

Description was changed from

==========
[NTP Snippets] Cleanups from clang-tidy

I ran clang-tidy
(https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md) on
components/ntp_snippets/ and fixed a bunch of the non-false-positives :)

BUG=none
==========

to

==========
[NTP Snippets] Cleanups from clang-tidy

I ran clang-tidy
(https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md) on
components/ntp_snippets/ and fixed a bunch of the non-false-positives :)

BUG=none

Committed: https://crrev.com/62e819e9d577e6a24d4199343fe244dee2bca4a1
Cr-Commit-Position: refs/heads/master@{#421173}
==========

[commit-bot: I haz the power, 2016-09-27 11:50:07]

Patchset 3 (id:??) landed as
https://crrev.com/62e819e9d577e6a24d4199343fe244dee2bca4a1
Cr-Commit-Position: refs/heads/master@{#421173}