Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: components/ntp_snippets/content_suggestions_service.cc

Issue 2368583002: [NTP Snippets] Cleanups from clang-tidy (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service.cc
diff --git a/components/ntp_snippets/content_suggestions_service.cc b/components/ntp_snippets/content_suggestions_service.cc
index cbd86d9b53eb79c88700e4db84ca9a1d5a9ad174..f141eabf19578f3f5eb5f8732a2d6df7a9045950 100644
--- a/components/ntp_snippets/content_suggestions_service.cc
+++ b/components/ntp_snippets/content_suggestions_service.cc
@@ -30,7 +30,7 @@ ContentSuggestionsService::ContentSuggestionsService(
history_service_observer_.Add(history_service);
}
-ContentSuggestionsService::~ContentSuggestionsService() {}
+ContentSuggestionsService::~ContentSuggestionsService() = default;
void ContentSuggestionsService::Shutdown() {
ntp_snippets_service_ = nullptr;
@@ -176,14 +176,14 @@ void ContentSuggestionsService::RegisterProvider(
void ContentSuggestionsService::OnNewSuggestions(
ContentSuggestionsProvider* provider,
Category category,
- std::vector<ContentSuggestion> new_suggestions) {
+ std::vector<ContentSuggestion> suggestions) {
if (RegisterCategoryIfRequired(provider, category))
NotifyCategoryStatusChanged(category);
if (!IsCategoryStatusAvailable(provider->GetCategoryStatus(category)))
return;
- suggestions_by_category_[category] = std::move(new_suggestions);
+ suggestions_by_category_[category] = std::move(suggestions);
// The positioning of the bookmarks category depends on whether it's empty.
// TODO(treib): Remove this temporary hack, crbug.com/640568.

Powered by Google App Engine
This is Rietveld 408576698