Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 2368583002: [NTP Snippets] Cleanups from clang-tidy (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_service.cc
diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc
index fb955cd0894cb2f080f8fe33b3a33f0c850593d5..f85d26a6f2ead673266c2c0b1c92189c5b9b92f2 100644
--- a/components/ntp_snippets/ntp_snippets_service.cc
+++ b/components/ntp_snippets/ntp_snippets_service.cc
@@ -226,8 +226,7 @@ NTPSnippetsService::NTPSnippetsService(
base::Unretained(this)));
}
-NTPSnippetsService::~NTPSnippetsService() {
-}
+NTPSnippetsService::~NTPSnippetsService() = default;
// static
void NTPSnippetsService::RegisterProfilePrefs(PrefRegistrySimple* registry) {
@@ -543,7 +542,7 @@ void NTPSnippetsService::OnSuggestionsChanged(
// for its callback.
NotifyNewSuggestions();
- FetchSnippetsFromHosts(hosts, /*force_request=*/false);
+ FetchSnippetsFromHosts(hosts, /*interactive_request=*/false);
}
void NTPSnippetsService::OnFetchFinished(
@@ -804,9 +803,8 @@ void NTPSnippetsService::OnSnippetImageFetchedFromDatabase(
// |image_decoder_| is null in tests.
if (image_decoder_ && !data.empty()) {
image_decoder_->DecodeImage(
- std::move(data),
- base::Bind(&NTPSnippetsService::OnSnippetImageDecodedFromDatabase,
- base::Unretained(this), callback, suggestion_id));
+ data, base::Bind(&NTPSnippetsService::OnSnippetImageDecodedFromDatabase,
+ base::Unretained(this), callback, suggestion_id));
return;
}
@@ -879,7 +877,7 @@ void NTPSnippetsService::EnterStateReady() {
// Either add a DCHECK here that we actually are allowed to do network I/O
// or change the logic so that some explicit call is always needed for the
// network request.
- FetchSnippets(/*force_request=*/false);
+ FetchSnippets(/*interactive_request=*/false);
fetch_when_ready_ = false;
}
« no previous file with comments | « components/ntp_snippets/ntp_snippets_service.h ('k') | components/ntp_snippets/ntp_snippets_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698