[NTP Snippets] Cleanups from clang-tidy

components/ntp_snippets/content_suggestions_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/content_suggestions_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 #include <utility>
@@ skipping 12 matching lines @@
     PrefService* pref_service)
     : state_(state),
       history_service_observer_(this),
       ntp_snippets_service_(nullptr),
       user_classifier_(pref_service) {
   // Can be null in tests.
   if (history_service)
     history_service_observer_.Add(history_service);
 }
 
-ContentSuggestionsService::~ContentSuggestionsService() {}
+ContentSuggestionsService::~ContentSuggestionsService() = default;
 
 void ContentSuggestionsService::Shutdown() {
   ntp_snippets_service_ = nullptr;
   id_category_map_.clear();
   suggestions_by_category_.clear();
   providers_by_category_.clear();
   categories_.clear();
   providers_.clear();
   state_ = State::DISABLED;
   FOR_EACH_OBSERVER(Observer, observers_, ContentSuggestionsServiceShutdown());
@@ skipping 142 matching lines @@
   DCHECK(state_ == State::ENABLED);
   providers_.push_back(std::move(provider));
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Private methods
 
 void ContentSuggestionsService::OnNewSuggestions(
     ContentSuggestionsProvider* provider,
     Category category,
-    std::vector<ContentSuggestion> new_suggestions) {

[Marc Treib, 2016/09/23 16:42:44]

To match the declaration in the header

+    std::vector<ContentSuggestion> suggestions) {
   if (RegisterCategoryIfRequired(provider, category))
     NotifyCategoryStatusChanged(category);
 
   if (!IsCategoryStatusAvailable(provider->GetCategoryStatus(category)))
     return;
 
   for (const ContentSuggestion& suggestion :
        suggestions_by_category_[category]) {
     id_category_map_.erase(suggestion.id());
   }
 
-  for (const ContentSuggestion& suggestion : new_suggestions)
+  for (const ContentSuggestion& suggestion : suggestions)
     id_category_map_.insert(std::make_pair(suggestion.id(), category));
 
-  suggestions_by_category_[category] = std::move(new_suggestions);
+  suggestions_by_category_[category] = std::move(suggestions);
 
   // The positioning of the bookmarks category depends on whether it's empty.
   // TODO(treib): Remove this temporary hack, crbug.com/640568.
   if (category.IsKnownCategory(KnownCategories::BOOKMARKS))
     SortCategories();
 
   FOR_EACH_OBSERVER(Observer, observers_, OnNewSuggestions(category));
 }
 
 void ContentSuggestionsService::OnCategoryStatusChanged(
@@ skipping 136 matching lines @@
           if (left.IsKnownCategory(KnownCategories::BOOKMARKS))
             return false;
           if (right.IsKnownCategory(KnownCategories::BOOKMARKS))
             return true;
         }
         return category_factory_.CompareCategories(left, right);
       });
 }
 
 }  // namespace ntp_snippets