Mark paragraph-related functions deprecated in VisibleUnits

Mark paragraph-related functions deprecated in VisibleUnits

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in editing/commands/ are switched to the deprecated
functions. Calls in other places have ensured valid VisiblePositions as input,
and hence, are calling the non-deprecated functions after this patch.

BUG=648949
Committed: https://crrev.com/58d3e91f04c7eb7847dade2b3f427da26dfd7379
Cr-Commit-Position: refs/heads/master@{#421063}

[Xiaocheng, 2016-09-23 02:55:58]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 02:56:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-23 03:05:02]

Description was changed from

==========
Mark paragraph-related functions deprecated in editing commands and
EditingUtilities.cpp

BUG=647219
==========

to

==========
Mark paragraph-related functions deprecated in editing commands and
EditingUtilities.cpp

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in EditingUtilities.cpp and editing/commands/ are
switched to the deprecated functions. Calls in other places have ensured
valid VisiblePositions as input, and hence, are calling the non-deprecated
functions after this patch.

BUG=647219
==========

[Xiaocheng, 2016-09-23 03:05:40]

Description was changed from

==========
Mark paragraph-related functions deprecated in editing commands and
EditingUtilities.cpp

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in EditingUtilities.cpp and editing/commands/ are
switched to the deprecated functions. Calls in other places have ensured
valid VisiblePositions as input, and hence, are calling the non-deprecated
functions after this patch.

BUG=647219
==========

to

==========
Mark paragraph-related functions deprecated in editing commands and
EditingUtilities.cpp

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in EditingUtilities.cpp and editing/commands/ are
switched to the deprecated functions. Calls in other places have ensured
valid VisiblePositions as input, and hence, are calling the non-deprecated
functions after this patch.

BUG=648949
==========

[Xiaocheng, 2016-09-23 04:02:56]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-23 04:02:56]

PTAL.

[commit-bot: I haz the power, 2016-09-23 04:14:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 04:14:41]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-23 06:34:45]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 06:34:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-23 06:35:10]

Description was changed from

==========
Mark paragraph-related functions deprecated in editing commands and
EditingUtilities.cpp

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in EditingUtilities.cpp and editing/commands/ are
switched to the deprecated functions. Calls in other places have ensured
valid VisiblePositions as input, and hence, are calling the non-deprecated
functions after this patch.

BUG=648949
==========

to

==========
Mark paragraph-related functions deprecated in editing commands and
EditingUtilities.cpp

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in editing/commands/ are switched to the deprecated
functions. Calls in other places have ensured valid VisiblePositions as input,
and hence, are calling the non-deprecated functions after this patch.

BUG=648949
==========

[commit-bot: I haz the power, 2016-09-23 09:05:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:05:34]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-26 01:04:40]

Description was changed from

==========
Mark paragraph-related functions deprecated in editing commands and
EditingUtilities.cpp

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in editing/commands/ are switched to the deprecated
functions. Calls in other places have ensured valid VisiblePositions as input,
and hence, are calling the non-deprecated functions after this patch.

BUG=648949
==========

to

==========
Mark paragraph-related functions deprecated in VisibleUnits

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in editing/commands/ are switched to the deprecated
functions. Calls in other places have ensured valid VisiblePositions as input,
and hence, are calling the non-deprecated functions after this patch.

BUG=648949
==========

[Xiaocheng, 2016-09-26 01:05:11]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 01:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-09-26 01:29:09]

lgtm w/ nits

https://codereview.chromium.org/2366693005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2366693005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1778:
DCHECK(a.isValid());
nit: Could you add "<< a" for ease of debug?

https://codereview.chromium.org/2366693005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1779:
DCHECK(b.isValid());
nit: Could you add "<< b" for ease of debug?

https://codereview.chromium.org/2366693005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1791:
DCHECK(pos.isValid());
nit: Could you add "<< pos" for ease of debugging?

[Xiaocheng, 2016-09-26 01:36:14]

https://codereview.chromium.org/2366693005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2366693005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1778:
DCHECK(a.isValid());
On 2016/09/26 at 01:29:09, Yosi_UTC9 wrote:
> nit: Could you add "<< a" for ease of debug?

I'm thinking about having a scope that asserts VP::isValid at the beginning and
disallows document lifecycle's transition within the scope. Then we can replace
basically all existing checks of VP::isValid with this scope.

WDYT?

[commit-bot: I haz the power, 2016-09-26 02:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 02:36:29]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xiaocheng, 2016-09-26 02:39:57]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 02:40:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 04:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 04:23:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2016-09-26 04:49:04]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 04:49:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-09-26 05:50:54]

On 2016/09/26 at 01:36:14, xiaochengh wrote:
>
https://codereview.chromium.org/2366693005/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):
> 
>
https://codereview.chromium.org/2366693005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1778:
DCHECK(a.isValid());
> On 2016/09/26 at 01:29:09, Yosi_UTC9 wrote:
> > nit: Could you add "<< a" for ease of debug?
> 
> I'm thinking about having a scope that asserts VP::isValid at the beginning
and disallows document lifecycle's transition within the scope. Then we can
replace basically all existing checks of VP::isValid with this scope.
> 
> WDYT?

We discuss offline. We don't make DocumentLifecycle::DisallowTransitionScope
ctor to take nullptr.

[commit-bot: I haz the power, 2016-09-26 06:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 06:43:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Xiaocheng, 2016-09-26 23:39:21]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-09-26 23:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2366693005/#ps40001
(title: "Add output for DCHECK")

[commit-bot: I haz the power, 2016-09-26 23:39:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:04:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 01:07:35]

Description was changed from

==========
Mark paragraph-related functions deprecated in VisibleUnits

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in editing/commands/ are switched to the deprecated
functions. Calls in other places have ensured valid VisiblePositions as input,
and hence, are calling the non-deprecated functions after this patch.

BUG=648949
==========

to

==========
Mark paragraph-related functions deprecated in VisibleUnits

This patch marks the following functions in VisibleUnits.cpp deprecated
because they accept invalid VisiblePositions as input:
- startOfParagraph
- endOfParagraph
- isStartOfParagraph
- isEndOfParagraph
- inSameParagraph
- startOfNextParagraph

This patch also creates the non-deprecated versions of these functions
that requires valid VisiblePositions as input.

Calls of these functions in editing/commands/ are switched to the deprecated
functions. Calls in other places have ensured valid VisiblePositions as input,
and hence, are calling the non-deprecated functions after this patch.

BUG=648949

Committed: https://crrev.com/58d3e91f04c7eb7847dade2b3f427da26dfd7379
Cr-Commit-Position: refs/heads/master@{#421063}
==========

[commit-bot: I haz the power, 2016-09-27 01:07:36]

Patchset 3 (id:??) landed as
https://crrev.com/58d3e91f04c7eb7847dade2b3f427da26dfd7379
Cr-Commit-Position: refs/heads/master@{#421063}